Fix Run.logs() returning nothing for a finished run - #4176
Merged
Conversation
`logs()` shared job lookup with `attach()`, which resolves `replica_num=None` to a running replica only. Reading logs must outlive the replica, so it now falls back to the lowest-numbered replica when none is running.
Restores the pre-rolling-deployment fallback for the whole lookup instead of wrapping it, and makes the choice deterministic when several replicas match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4175
Run.logs()returned an empty iterator for any run in a terminal state, with no error, whiledstack logsprinted the same run's logs - the CLI passes--replica 0by default and so never took that path.replica_numisNoneand no replica is running, restoring the behaviour_find_jobhad before Rolling deployment for services #2821 added the running-replica requirement for rolling deployments.Run.jobs.attach()resolve a replica on aDONErun, which makes its existing "read logs from the websocket" branch reachable; a failed or terminated run still returns early before the job is used.return []withreturnin thelogs()generator, where the value was never visible to the caller.AI assistance: written with Claude Code.