Skip to content

Honor disabled timeouts during token refresh #608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Shubham-Padkonde wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Honor disabled timeouts during token refresh #608

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions dropbox/dropbox_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,13 +444,9 @@ def refresh_access_token(self, host=API_HOST, scope=None):
scope = " ".join(scope)
body["scope"] = scope

timeout = DEFAULT_TIMEOUT
if self._timeout:
timeout = self._timeout

attempt = 0
while True:
res = self._session.post(url, data=body, timeout=timeout)
res = self._session.post(url, data=body, timeout=self._timeout)
try:
self.raise_dropbox_error_for_resp(res)
break
Expand Down
11 changes: 11 additions & 0 deletions test/unit/test_dropbox_unit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -537,6 +537,17 @@ def test_check_refresh_with_legacy_token(self, session_instance):
dbx.check_and_refresh_access_token()
session_instance.post.assert_not_called()

@pytest.mark.parametrize("timeout", [None, 30])
def test_refresh_respects_client_timeout(self, session_instance, timeout):
dbx = Dropbox(
oauth2_refresh_token=REFRESH_TOKEN,
app_key=APP_KEY,
session=session_instance,
timeout=timeout,
)
dbx.refresh_access_token()
assert session_instance.post.call_args.kwargs["timeout"] == timeout

def test_check_refresh_with_valid_online_token(self, session_instance):
# Test Online Case w/ valid access
dbx = Dropbox(
Expand Down
Loading