[Prototype] Migrate spec-update to shared reusable workflow - #572
Closed
cguldner wants to merge 1 commit into
Closed
[Prototype] Migrate spec-update to shared reusable workflow#572cguldner wants to merge 1 commit into
cguldner wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #572 +/- ##
=======================================
Coverage 65.18% 65.18%
=======================================
Files 34 34
Lines 65830 65830
Branches 4687 4687
=======================================
Hits 42910 42910
Misses 22759 22759
Partials 161 161
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Closing for now — will revisit once dropbox/sdk-build-tools is created (the reusable workflow needs an org-hosted home; calling it from cguldner/ hit a startup_failure due to org Actions policy). Branch retained. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prototype — do not merge. Demonstrates consolidating the duplicated
spec_update.ymlinto a shared reusable workflow.spec_update.ymlwith an 18-line thin caller pointing atcguldner/sdk-build-tools/.github/workflows/spec-update.yml@master(prototype location; intended homedropbox/sdk-build-tools).scripts/spec-update/generate.sh— the per-repo codegen (the only repo-specific part), runnable/testable locally.Before merging / rolling out
oidc-github-dropbox-dropbox-sdk-python-repotrust policy keys on callersub(repo:dropbox/dropbox-sdk-python:*), notjob_workflow_ref. If it pinsjob_workflow_ref, OIDC breaks until the policy is updated.selectedallow-list).workflow_dispatchon this branch before merge.To test
Trigger the
Spec Updateworkflow on branchprototype-reusable-spec-updatevia workflow_dispatch and confirm the AWS auth + token steps succeed and a spec-update PR is produced identical in shape to today's.