[#2715] Prefixed all tooling scripts with 'vortex-' and surfaced user-facing ones as Composer binaries.#2741
Open
AlexSkrypnyk wants to merge 6 commits into
Open
[#2715] Prefixed all tooling scripts with 'vortex-' and surfaced user-facing ones as Composer binaries.#2741AlexSkrypnyk wants to merge 6 commits into
AlexSkrypnyk wants to merge 6 commits into
Conversation
…ing ones as binaries.
|
Warning Review limit reached
More reviews will be available in 21 minutes and 27 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (7)
WalkthroughThe PR renames Vortex tooling entrypoints to ChangesVortex binary namespace rollout
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Caution Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted. Error details |
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2741 +/- ##
==========================================
- Coverage 86.67% 86.24% -0.44%
==========================================
Files 96 89 -7
Lines 4719 4564 -155
Branches 47 3 -44
==========================================
- Hits 4090 3936 -154
+ Misses 629 628 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
📖 Documentation preview for this pull request has been deployed to Netlify: https://6a3e87ccad4fcf540123e664--vortex-docs.netlify.app This preview is rebuilt on every commit and is not the production documentation site. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
scripts/vortex-tooling.sh (1)
23-25: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick winDon't exit before backfilling the new
vendor/binentrypoints.Because Line 24 still short-circuits on the old package directory alone, any checkout that already bootstrapped the pre-rename tooling will never run this new proxy-move block. After this PR,
.ahoy.ymland the hooks call./vendor/bin/vortex-*, so those upgraded worktrees will fail until a fullcomposer installhappens. Please gate the early exit on the new binaries already existing (or on the installed tooling version matching) and regenerate them when they're missing.Also applies to: 85-96
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@scripts/vortex-tooling.sh` around lines 23 - 25, The early return in vortex-tooling.sh is still keyed only off the legacy vendor/drevops/vortex-tooling directory, so upgraded checkouts can skip the new vendor/bin proxy generation and break the renamed vortex-* entrypoints. Update the exit condition in vortex-tooling.sh (and the proxy-move block it guards) to only short-circuit when the new binaries are already present or the installed tooling version matches, and make sure the backfill logic runs whenever vendor/bin/vortex-* is missing.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.vortex/tooling/playground/try-notify-email.sh:
- Line 75: Update the try-notify-email.sh script to invoke the published
Composer binary instead of the internal package source path. Replace the
hardcoded vortex-tooling src reference with the stable vendor/bin/vortex-notify
entrypoint so the script uses the intended public contract; the relevant symbol
to locate is the vortex-notify command invocation in the shell script.
In @.vortex/tooling/playground/try-notify-github.sh:
- Line 84: The playground script is still invoking the package-internal
vortex-notify path instead of the Composer-installed binary, so update
try-notify-github.sh to use vendor/bin/vortex-notify consistently. Make the
change in the command assignment near the existing vortex-notify reference so
the script exercises the published interface rather than src/vortex-notify.
In @.vortex/tooling/playground/try-notify-jira.sh:
- Line 81: The playground runner is still invoking the package source path
instead of the published entrypoint. Update the command in try-notify-jira.sh to
use vendor/bin/vortex-notify rather than the direct
vendor/drevops/vortex-tooling/src/vortex-notify target, so the script exercises
the same binary exposed by the package.
---
Outside diff comments:
In `@scripts/vortex-tooling.sh`:
- Around line 23-25: The early return in vortex-tooling.sh is still keyed only
off the legacy vendor/drevops/vortex-tooling directory, so upgraded checkouts
can skip the new vendor/bin proxy generation and break the renamed vortex-*
entrypoints. Update the exit condition in vortex-tooling.sh (and the proxy-move
block it guards) to only short-circuit when the new binaries are already present
or the installed tooling version matches, and make sure the backfill logic runs
whenever vendor/bin/vortex-* is missing.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: bbd37e8f-f917-4db9-9265-24f2b3c10e52
⛔ Files ignored due to path filters (70)
.vortex/installer/tests/Fixtures/handler_process/_baseline/.ahoy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/_baseline/.github/workflows/build-test-deploy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/_baseline/scripts/vortex-tooling.shis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/ciprovider_circleci/.circleci/config.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/code_coverage_provider_codecov_circleci/.circleci/config.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/custom_modules_search_without_solr/.ahoy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/db_fetch_source_acquia/.github/workflows/build-test-deploy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/deploy_types_all_circleci/.circleci/config.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/deploy_types_none_circleci/.circleci/config.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/deploy_types_none_gha/.github/workflows/build-test-deploy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/deps_updates_provider_ci_circleci/.circleci/config.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/hosting_acquia/.github/workflows/build-test-deploy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/hosting_acquia/hooks/library/copy-db.shis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/hosting_acquia/hooks/library/copy-files.shis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/hosting_acquia/hooks/library/notify-deployment.shis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/hosting_acquia/hooks/library/provision.shis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/hosting_acquia/hooks/library/purge-cache.shis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/hosting_lagoon/.lagoon.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/hosting_project_name___acquia/.github/workflows/build-test-deploy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/hosting_project_name___acquia/hooks/library/copy-db.shis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/hosting_project_name___acquia/hooks/library/copy-files.shis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/hosting_project_name___acquia/hooks/library/notify-deployment.shis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/hosting_project_name___acquia/hooks/library/provision.shis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/hosting_project_name___acquia/hooks/library/purge-cache.shis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/hosting_project_name___lagoon/.lagoon.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_disabled_circleci/.circleci/config.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_disabled_lagoon/.lagoon.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_enabled/.ahoy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_enabled/.github/workflows/build-test-deploy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_enabled_circleci/.ahoy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_enabled_circleci/.circleci/config.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_enabled_lagoon/.ahoy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_enabled_lagoon/.github/workflows/build-test-deploy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_enabled_lagoon/.lagoon.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_acquia/.ahoy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_acquia/.github/workflows/build-test-deploy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_container_registry/.ahoy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_container_registry/.github/workflows/build-test-deploy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_ftp/.ahoy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_ftp/.github/workflows/build-test-deploy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_lagoon/.ahoy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_lagoon/.github/workflows/build-test-deploy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_s3/.ahoy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_s3/.github/workflows/build-test-deploy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_url/.ahoy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_url/.github/workflows/build-test-deploy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/provision_database_lagoon/.lagoon.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/provision_profile/.ahoy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/provision_profile/.github/workflows/build-test-deploy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/services_no_solr/.ahoy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/services_none/.ahoy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/timezone_circleci/.circleci/config.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_be_lint_circleci/.circleci/config.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_be_tests_circleci/.circleci/config.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_fe_lint/.github/workflows/build-test-deploy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_fe_lint_circleci/.circleci/config.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_fe_lint_no_theme/.ahoy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_fe_lint_no_theme/.github/workflows/build-test-deploy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_fe_lint_no_theme_circleci/.ahoy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_fe_lint_no_theme_circleci/.circleci/config.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_no_behat_circleci/.circleci/config.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_no_eslint_circleci/.circleci/config.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_no_jest/.github/workflows/build-test-deploy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_no_jest_circleci/.circleci/config.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_no_phpcs_circleci/.circleci/config.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_no_phpstan_circleci/.circleci/config.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_no_phpunit_circleci/.circleci/config.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_no_rector_circleci/.circleci/config.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_no_stylelint_circleci/.circleci/config.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_none/.github/workflows/build-test-deploy.ymlis excluded by!.vortex/installer/tests/Fixtures/**
📒 Files selected for processing (101)
.ahoy.yml.circleci/config.yml.circleci/vortex-test-common.yml.github/workflows/build-test-deploy.yml.lagoon.yml.vortex/CLAUDE.md.vortex/docs/content/deployment/README.mdx.vortex/docs/content/drupal/provision.mdx.vortex/tests/phpunit/Functional/DockerComposeWorkflowTest.php.vortex/tests/phpunit/Traits/SutTrait.php.vortex/tooling/README.md.vortex/tooling/composer.json.vortex/tooling/playground/README.md.vortex/tooling/playground/try-fetch-db-s3.sh.vortex/tooling/playground/try-notify-email.sh.vortex/tooling/playground/try-notify-github.sh.vortex/tooling/playground/try-notify-jira.sh.vortex/tooling/playground/try-notify-newrelic.sh.vortex/tooling/playground/try-notify-slack.sh.vortex/tooling/playground/try-notify-webhook.sh.vortex/tooling/playground/try-push-db-s3.sh.vortex/tooling/src/vortex-deploy.vortex/tooling/src/vortex-deploy-artifact.vortex/tooling/src/vortex-deploy-lagoon.vortex/tooling/src/vortex-deploy-webhook.vortex/tooling/src/vortex-doctor.vortex/tooling/src/vortex-export-db.vortex/tooling/src/vortex-export-db-file.vortex/tooling/src/vortex-export-db-image.vortex/tooling/src/vortex-fetch-db.vortex/tooling/src/vortex-fetch-db-acquia.vortex/tooling/src/vortex-fetch-db-container-registry.vortex/tooling/src/vortex-fetch-db-ftp.vortex/tooling/src/vortex-fetch-db-lagoon.vortex/tooling/src/vortex-fetch-db-s3.vortex/tooling/src/vortex-fetch-db-url.vortex/tooling/src/vortex-import-db.vortex/tooling/src/vortex-import-db-file.vortex/tooling/src/vortex-info.vortex/tooling/src/vortex-login.vortex/tooling/src/vortex-login-container-registry.vortex/tooling/src/vortex-logout.vortex/tooling/src/vortex-notify.vortex/tooling/src/vortex-notify-diffy.vortex/tooling/src/vortex-notify-email.vortex/tooling/src/vortex-notify-github.vortex/tooling/src/vortex-notify-jira.vortex/tooling/src/vortex-notify-newrelic.vortex/tooling/src/vortex-notify-slack.vortex/tooling/src/vortex-notify-webhook.vortex/tooling/src/vortex-provision.vortex/tooling/src/vortex-provision-sanitize-db.vortex/tooling/src/vortex-push-container-registry.vortex/tooling/src/vortex-push-db-image.vortex/tooling/src/vortex-push-db-s3.vortex/tooling/src/vortex-reset.vortex/tooling/src/vortex-setup-ssh.vortex/tooling/src/vortex-task.vortex/tooling/src/vortex-task-copy-db-acquia.vortex/tooling/src/vortex-task-copy-files-acquia.vortex/tooling/src/vortex-task-custom-lagoon.vortex/tooling/src/vortex-task-purge-cache-acquia.vortex/tooling/src/vortex-update.vortex/tooling/tests/unit/deploy-artifact.bats.vortex/tooling/tests/unit/deploy-lagoon.bats.vortex/tooling/tests/unit/deploy-webhook.bats.vortex/tooling/tests/unit/deploy.bats.vortex/tooling/tests/unit/export-db.bats.vortex/tooling/tests/unit/fetch-db-acquia.bats.vortex/tooling/tests/unit/fetch-db-container-registry.bats.vortex/tooling/tests/unit/fetch-db-ftp.bats.vortex/tooling/tests/unit/fetch-db-lagoon.bats.vortex/tooling/tests/unit/fetch-db-s3.bats.vortex/tooling/tests/unit/fetch-db-url.bats.vortex/tooling/tests/unit/fetch-db.bats.vortex/tooling/tests/unit/import-db-file.bats.vortex/tooling/tests/unit/import-db.bats.vortex/tooling/tests/unit/login-container-registry.bats.vortex/tooling/tests/unit/notify-diffy.bats.vortex/tooling/tests/unit/notify-email.bats.vortex/tooling/tests/unit/notify-github.bats.vortex/tooling/tests/unit/notify-jira.bats.vortex/tooling/tests/unit/notify-newrelic.bats.vortex/tooling/tests/unit/notify-slack.bats.vortex/tooling/tests/unit/notify-webhook.bats.vortex/tooling/tests/unit/notify.bats.vortex/tooling/tests/unit/provision.bats.vortex/tooling/tests/unit/push-container-registry.bats.vortex/tooling/tests/unit/push-db-image.bats.vortex/tooling/tests/unit/push-db-s3.bats.vortex/tooling/tests/unit/reset.bats.vortex/tooling/tests/unit/setup-ssh.bats.vortex/tooling/tests/unit/task.bats.vortex/tooling/tests/unit/update-vortex.batscomposer.jsonhooks/library/copy-db.shhooks/library/copy-files.shhooks/library/notify-deployment.shhooks/library/provision.shhooks/library/purge-cache.shscripts/vortex-tooling.sh
…s, and BATS stubs.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Code coverage (threshold: 90%) Per-class coverage |
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
Member
Author
|
Code coverage (threshold: 90%) Per-class coverage |
AlexSkrypnyk
added
the
Needs review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2715
Summary
All 42 tooling shell scripts in
drevops/vortex-toolingare now prefixed withvortex-and the 15 user-facing entrypoints (deploy,doctor,export-db,fetch-db,import-db,info,login,login-container-registry,logout,notify,provision,push-db-image,reset,task,update) are declared in the package'sbinarray so Composer installs them asvendor/bin/vortex-*. Internal sub-scripts (e.g.vortex-deploy-artifact,vortex-fetch-db-s3) gain the prefix but are not surfaced as binaries. All callers -.ahoy.yml,.lagoon.yml, GitHub Actions, CircleCI, Acquia hooks, and the host-sidescripts/vortex-tooling.shbootstrap - now referencevendor/bin/vortex-*. The rootcomposer.jsonconstraint is tightened from^1.2.0to~1.2.0to allow patch-only updates for the tooling package.Changes
.vortex/tooling/src/from<name>tovortex-<name>(includingupdate-vortex->vortex-update) and updated every internal sibling reference within those scripts.binarray to.vortex/tooling/composer.jsonlisting the user-facing entrypoints; sub-scripts are prefixed but unlisted.vendor/bin/vortex-*across.ahoy.yml,.lagoon.yml,.github/workflows/build-test-deploy.yml,.circleci/config.yml, andhooks/library/*.sh.scripts/vortex-tooling.shto move thevortex-*bin proxies from the throwaway Composer project intovendor/bin/so host-side recipes can invokevendor/bin/vortex-*before the project's fullcomposer installhas run.composer.jsonconstraint from^1.2.0to~1.2.0..vortex/tooling/tests/unit/and the PHPUnit test harness (SutTrait,DockerComposeWorkflowTest) to reference the new script paths..circleci/vortex-test-common.yml.Screenshots
N/A - non-visual change.
Before / After
Summary by CodeRabbit
New Features
vendor/bin/vortex-*binaries for local scripts and automation.Bug Fixes
Documentation
vendor/bin/vortex-*.Tests
vendor/bin/vortex-*tooling entrypoints.