Skip to content

[#2729] Clarified that 'export-db' and 'import-db' run on the host or in the container.#2732

Merged
AlexSkrypnyk merged 1 commit into
mainfrom
feature/2729-db-router-mode
Jun 25, 2026
Merged

[#2729] Clarified that 'export-db' and 'import-db' run on the host or in the container.#2732
AlexSkrypnyk merged 1 commit into
mainfrom
feature/2729-db-router-mode

Conversation

@AlexSkrypnyk

Copy link
Copy Markdown
Member

Closes #2729

Summary

Corrected the header comment in export-db and import-db to accurately describe their dual-mode routing behaviour. Both scripts define is_host() and either delegate into the container via docker compose exec (when running on the host) or execute the worker script directly (when already inside the container). The old comment falsely implied host-only execution. The other 18 tooling scripts that share the original wording are genuinely host-only and were intentionally left unchanged.

Changes

  • .vortex/tooling/src/export-db - updated header comment to reflect host-or-container routing.
  • .vortex/tooling/src/import-db - same correction.

Before / After

┌─────────────────────────────────────────────────────────────────────┐
│  BEFORE (misleading - implied host-only)                            │
├─────────────────────────────────────────────────────────────────────┤
│  # IMPORTANT! This script runs outside the container on the host    │
│  # system.                                                          │
└─────────────────────────────────────────────────────────────────────┘

┌─────────────────────────────────────────────────────────────────────┐
│  AFTER (accurate - describes dual-mode routing)                     │
├─────────────────────────────────────────────────────────────────────┤
│  # IMPORTANT! This script runs on the host or inside the            │
│  # container, routing the work to the appropriate location.         │
└─────────────────────────────────────────────────────────────────────┘

Routing logic (both scripts):

  HOST                              CONTAINER
  ┌──────────────────┐              ┌──────────────────────────┐
  │  export-db /     │─is_host()──▶ │  docker compose exec -T  │
  │  import-db       │    true      │  cli ./<worker>-db-file  │
  │  (router)        │              └──────────────────────────┘
  │                  │─is_host()──▶ runs <worker>-db-file
  │                  │    false       directly in place
  └──────────────────┘

@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@AlexSkrypnyk, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 19 minutes and 30 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 4ab91493-f699-4f69-92cf-82d84164bb45

📥 Commits

Reviewing files that changed from the base of the PR and between 14e851f and 5a71246.

📒 Files selected for processing (2)
  • .vortex/tooling/src/export-db
  • .vortex/tooling/src/import-db
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/2729-db-router-mode

Comment @coderabbitai help to get the list of available commands.

@AlexSkrypnyk AlexSkrypnyk added this to the 1.40.0 milestone Jun 25, 2026
@AlexSkrypnyk AlexSkrypnyk added the A2 Working clone index A2 label Jun 25, 2026
@github-actions

Copy link
Copy Markdown

Code coverage (threshold: 90%)

  Classes: 100.00% (1/1)
  Methods: 100.00% (2/2)
  Lines:   98.55% (204/207)
Per-class coverage
Drupal\ys_demo\Plugin\Block\CounterBlock
  Methods: 100.00% ( 2/ 2)   Lines: 100.00% ( 10/ 10)

@AlexSkrypnyk

This comment has been minimized.

2 similar comments
@AlexSkrypnyk

This comment has been minimized.

@AlexSkrypnyk

Copy link
Copy Markdown
Member Author

Code coverage (threshold: 90%)

  Classes: 100.00% (1/1)
  Methods: 100.00% (2/2)
  Lines:   98.55% (204/207)
Per-class coverage
Drupal\ys_demo\Plugin\Block\CounterBlock
  Methods: 100.00% ( 2/ 2)   Lines: 100.00% ( 10/ 10)

@github-actions

Copy link
Copy Markdown

📖 Documentation preview for this pull request has been deployed to Netlify:

https://6a3db03f02c1088633b5ddd5--vortex-docs.netlify.app

This preview is rebuilt on every commit and is not the production documentation site.

@codecov

codecov Bot commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.22%. Comparing base (14e851f) to head (5a71246).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2732      +/-   ##
==========================================
- Coverage   86.67%   86.22%   -0.45%     
==========================================
  Files          96       89       -7     
  Lines        4719     4560     -159     
  Branches       47        3      -44     
==========================================
- Hits         4090     3932     -158     
+ Misses        629      628       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AlexSkrypnyk AlexSkrypnyk merged commit 122a7fb into main Jun 25, 2026
37 of 38 checks passed
@AlexSkrypnyk AlexSkrypnyk deleted the feature/2729-db-router-mode branch June 25, 2026 22:54
@github-project-automation github-project-automation Bot moved this from BACKLOG to Release queue in Vortex 1.x Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A2 Working clone index A2

Projects

Status: Release queue

Development

Successfully merging this pull request may close these issues.

Clarify that 'export-db' and 'import-db' run on the host or in the container.

1 participant