[#2726] Renamed the 'download-db' command, variables and installer source to 'fetch'.#2730
Merged
Merged
Conversation
…bles and installer source.
…ag to ignore a leaked 'VORTEX_FETCH_DB_URL'.
… setup to prevent demo URL leakage.
|
Warning Review limit reached
More reviews will be available in 2 minutes and 9 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
WalkthroughThe PR renames database download flows to fetch flows across command entrypoints, CI and hosting configuration, installer prompt handling, tests, and documentation. It also updates the associated environment variables, semaphore names, and DB2 file naming. ChangesDatabase fetch rename
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.vortex/installer/src/Prompts/Handlers/Internal.php (1)
145-168: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueStale "download source" wording in comments.
These comments still describe the source selection as a "download source" / "downloading from container registry", but this PR renames the concept to fetch. Aligning the comments keeps the terminology consistent with
DatabaseFetchSourceand the user-facing messages.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.vortex/installer/src/Prompts/Handlers/Internal.php around lines 145 - 168, The comments in Internal::shouldEnableDemoMode still use the old “download source” wording and should be updated to the new fetch terminology for consistency. Edit the explanatory comments around the DatabaseFetchSource checks so they refer to “fetch source”/“fetching” instead of “download source”/“downloading,” while keeping the logic in the same Internal::shouldEnableDemoMode flow unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.vortex/docs/content/architecture.mdx:
- Around line 217-223: The docs example uses the wrong tooling entrypoint name,
so update the architecture text to reference the actual script name used
elsewhere in this PR, namely the fetch-db entrypoint without the .sh suffix.
Make the same naming correction wherever the example mentions fetch-db.sh so
readers are pointed to the real command path and not a nonexistent script.
In @.vortex/installer/tests/Unit/Utils/FileManagerTest.php:
- Line 212: The test method name is still tied to the old download terminology
even though it now covers the fetch-skip behavior. Rename
FileManagerTest::testPrepareDemoWithDownloadSkip to match the updated flag
naming, using testPrepareDemoWithFetchSkip so the method name stays aligned with
the behavior under test.
In @.vortex/tests/generate-vortex-dev-circleci:
- Around line 71-72: The fetch-db source mapping in the generator is using the
wrong value, so the DIDI-II CircleCI job won’t take the container-registry
branch. Update the generator in generate-vortex-dev-circleci so
VORTEX_FETCH_DB_SOURCE is emitted as container_registry (the value recognized by
fetch-db), then regenerate the CircleCI config to keep
.circleci/vortex-test-common.yml in sync.
---
Outside diff comments:
In @.vortex/installer/src/Prompts/Handlers/Internal.php:
- Around line 145-168: The comments in Internal::shouldEnableDemoMode still use
the old “download source” wording and should be updated to the new fetch
terminology for consistency. Edit the explanatory comments around the
DatabaseFetchSource checks so they refer to “fetch source”/“fetching” instead of
“download source”/“downloading,” while keeping the logic in the same
Internal::shouldEnableDemoMode flow unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 6a1a69cb-e583-43e8-8a2b-ab75bf9e5be5
⛔ Files ignored due to path filters (183)
.vortex/docs/static/img/diagram-scripts-dark.svgis excluded by!**/*.svg.vortex/docs/static/img/diagram-scripts-light.svgis excluded by!**/*.svg.vortex/installer/tests/Fixtures/handler_process/_baseline/.ahoy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/_baseline/.envis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/_baseline/.env.local.exampleis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/_baseline/.github/workflows/build-test-deploy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/_baseline/AGENTS.mdis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/_baseline/README.mdis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/_baseline/scripts/vortex-tooling.shis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/ciprovider_circleci/.circleci/config.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/code_coverage_provider_codecov_circleci/.circleci/config.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/db_download_source_ftp/.env.local.exampleis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/db_download_source_lagoon/.env.local.exampleis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/db_download_source_s3/.env.local.exampleis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/db_download_source_url/.ignorecontentis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/db_fetch_source_acquia/.envis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/db_fetch_source_acquia/.env.local.exampleis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/db_fetch_source_acquia/.github/workflows/build-test-deploy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/db_fetch_source_container_registry/.envis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/db_fetch_source_container_registry/.env.local.exampleis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/db_fetch_source_ftp/.envis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/db_fetch_source_ftp/.env.local.exampleis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/db_fetch_source_lagoon/.envis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/db_fetch_source_lagoon/.env.local.exampleis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/db_fetch_source_s3/.envis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/db_fetch_source_s3/.env.local.exampleis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/deploy_types_all_circleci/.circleci/config.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/deploy_types_none_circleci/.circleci/config.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/deps_updates_provider_ci_circleci/.circleci/config.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/hosting_acquia/.envis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/hosting_acquia/.env.local.exampleis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/hosting_acquia/.github/workflows/build-test-deploy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/hosting_acquia/README.mdis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/hosting_lagoon/.envis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/hosting_lagoon/.env.local.exampleis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/hosting_lagoon/.lagoon.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/hosting_lagoon/README.mdis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/hosting_project_name___acquia/.envis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/hosting_project_name___acquia/.env.local.exampleis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/hosting_project_name___acquia/.github/workflows/build-test-deploy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/hosting_project_name___acquia/README.mdis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/hosting_project_name___lagoon/.envis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/hosting_project_name___lagoon/.env.local.exampleis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/hosting_project_name___lagoon/.lagoon.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/hosting_project_name___lagoon/README.mdis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_disabled_circleci/.circleci/config.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_disabled_lagoon/.envis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_disabled_lagoon/.env.local.exampleis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_disabled_lagoon/.lagoon.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_disabled_lagoon/README.mdis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_download_source_s3/.ahoy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_download_source_s3/.github/workflows/build-test-deploy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_download_source_s3/scripts/provision-20-migration.shis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_download_source_url/.ahoy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_download_source_url/.github/workflows/build-test-deploy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_download_source_url/scripts/provision-20-migration.shis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_enabled/.ahoy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_enabled/.envis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_enabled/.github/workflows/build-test-deploy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_enabled/scripts/provision-20-migration.shis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_enabled_circleci/.ahoy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_enabled_circleci/.circleci/config.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_enabled_circleci/.envis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_enabled_circleci/scripts/provision-20-migration.shis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_enabled_lagoon/.ahoy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_enabled_lagoon/.envis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_enabled_lagoon/.env.local.exampleis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_enabled_lagoon/.github/workflows/build-test-deploy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_enabled_lagoon/.lagoon.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_enabled_lagoon/README.mdis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_enabled_lagoon/scripts/provision-20-migration.shis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_acquia/.ahoy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_acquia/.envis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_acquia/.github/workflows/build-test-deploy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_acquia/.gitignoreis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_acquia/composer.jsonis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_acquia/docker-compose.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_acquia/scripts/provision-20-migration.shis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_acquia/tests/phpunit/Drupal/DatabaseSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_acquia/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_acquia/tests/phpunit/Drupal/SettingsTestCase.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_acquia/web/modules/custom/ys_migrate/migrations/ys_migrate_categories.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_acquia/web/modules/custom/ys_migrate/ys_migrate.info.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_acquia/web/sites/default/settings.migration.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_acquia/web/sites/default/settings.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_container_registry/.ahoy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_container_registry/.envis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_container_registry/.github/workflows/build-test-deploy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_container_registry/.gitignoreis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_container_registry/composer.jsonis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_container_registry/docker-compose.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_container_registry/scripts/provision-20-migration.shis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_container_registry/tests/phpunit/Drupal/DatabaseSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_container_registry/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_container_registry/tests/phpunit/Drupal/SettingsTestCase.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_container_registry/web/modules/custom/ys_migrate/migrations/ys_migrate_categories.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_container_registry/web/modules/custom/ys_migrate/ys_migrate.info.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_container_registry/web/sites/default/settings.migration.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_container_registry/web/sites/default/settings.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_ftp/.ahoy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_ftp/.envis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_ftp/.github/workflows/build-test-deploy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_ftp/.gitignoreis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_ftp/composer.jsonis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_ftp/docker-compose.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_ftp/scripts/provision-20-migration.shis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_ftp/tests/phpunit/Drupal/DatabaseSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_ftp/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_ftp/tests/phpunit/Drupal/SettingsTestCase.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_ftp/web/modules/custom/ys_migrate/migrations/ys_migrate_categories.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_ftp/web/modules/custom/ys_migrate/ys_migrate.info.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_ftp/web/sites/default/settings.migration.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_ftp/web/sites/default/settings.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_lagoon/.ahoy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_lagoon/.envis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_lagoon/.github/workflows/build-test-deploy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_lagoon/.gitignoreis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_lagoon/composer.jsonis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_lagoon/docker-compose.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_lagoon/scripts/provision-20-migration.shis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_lagoon/tests/phpunit/Drupal/DatabaseSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_lagoon/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_lagoon/tests/phpunit/Drupal/SettingsTestCase.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_lagoon/web/modules/custom/ys_migrate/migrations/ys_migrate_categories.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_lagoon/web/modules/custom/ys_migrate/ys_migrate.info.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_lagoon/web/sites/default/settings.migration.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_lagoon/web/sites/default/settings.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_s3/.ahoy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_s3/.envis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_s3/.github/workflows/build-test-deploy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_s3/.gitignoreis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_s3/composer.jsonis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_s3/docker-compose.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_s3/scripts/provision-20-migration.shis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_s3/tests/phpunit/Drupal/DatabaseSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_s3/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_s3/tests/phpunit/Drupal/SettingsTestCase.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_s3/web/modules/custom/ys_migrate/migrations/ys_migrate_categories.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_s3/web/modules/custom/ys_migrate/ys_migrate.info.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_s3/web/sites/default/settings.migration.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_s3/web/sites/default/settings.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_url/.ahoy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_url/.envis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_url/.github/workflows/build-test-deploy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_url/.gitignoreis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_url/composer.jsonis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_url/docker-compose.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_url/scripts/provision-20-migration.shis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_url/tests/phpunit/Drupal/DatabaseSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_url/tests/phpunit/Drupal/EnvironmentSettingsTest.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_url/tests/phpunit/Drupal/SettingsTestCase.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_url/web/modules/custom/ys_migrate/migrations/ys_migrate_categories.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_url/web/modules/custom/ys_migrate/ys_migrate.info.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_url/web/sites/default/settings.migration.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/migration_fetch_source_url/web/sites/default/settings.phpis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/provision_database_lagoon/.envis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/provision_database_lagoon/.env.local.exampleis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/provision_database_lagoon/.lagoon.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/provision_database_lagoon/README.mdis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/provision_profile/.ahoy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/provision_profile/.envis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/provision_profile/.env.local.exampleis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/provision_profile/.github/workflows/build-test-deploy.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/provision_profile/README.mdis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/starter_drupal_cms_profile/.envis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/starter_drupal_profile/.envis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/theme_custom_non_vortex/.envis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/timezone_circleci/.circleci/config.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_be_lint_circleci/.circleci/config.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_be_tests_circleci/.circleci/config.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_fe_lint_circleci/.circleci/config.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_groups_no_fe_lint_no_theme_circleci/.circleci/config.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_no_behat_circleci/.circleci/config.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_no_eslint_circleci/.circleci/config.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_no_jest_circleci/.circleci/config.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_no_phpcs_circleci/.circleci/config.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_no_phpstan_circleci/.circleci/config.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_no_phpunit_circleci/.circleci/config.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_no_rector_circleci/.circleci/config.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/tools_no_stylelint_circleci/.circleci/config.ymlis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/schema/invalid_database_source.jsonis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/schema/valid_database_provision.jsonis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/schema/valid_migration.jsonis excluded by!.vortex/installer/tests/Fixtures/**
📒 Files selected for processing (85)
.ahoy.yml.circleci/config.yml.circleci/vortex-test-common.yml.env.env.local.example.github/workflows/build-test-deploy.yml.lagoon.yml.vortex/docs/content/architecture.mdx.vortex/docs/content/continuous-integration/README.mdx.vortex/docs/content/development/database.mdx.vortex/docs/content/development/variables.mdx.vortex/docs/content/drupal/migrations.mdx.vortex/docs/content/features.mdx.vortex/docs/content/hosting/acquia.mdx.vortex/docs/content/hosting/lagoon.mdx.vortex/docs/content/installation.mdx.vortex/docs/content/tools/drush.mdx.vortex/installer/src/Prompts/Handlers/DatabaseFetchSource.php.vortex/installer/src/Prompts/Handlers/DatabaseImage.php.vortex/installer/src/Prompts/Handlers/HostingProvider.php.vortex/installer/src/Prompts/Handlers/Internal.php.vortex/installer/src/Prompts/Handlers/MigrationFetchSource.php.vortex/installer/src/Prompts/Handlers/MigrationImage.php.vortex/installer/src/Prompts/PromptManager.php.vortex/installer/src/Utils/Config.php.vortex/installer/src/Utils/FileManager.php.vortex/installer/src/Utils/OptionsResolver.php.vortex/installer/tests/Functional/Command/InstallCommandTest.php.vortex/installer/tests/Functional/Command/SchemaValidateCommandTest.php.vortex/installer/tests/Functional/FunctionalTestCase.php.vortex/installer/tests/Functional/Handlers/BaselineHandlerProcessTest.php.vortex/installer/tests/Functional/Handlers/DatabaseDownloadSourceHandlerProcessTest.php.vortex/installer/tests/Functional/Handlers/DatabaseFetchSourceHandlerProcessTest.php.vortex/installer/tests/Functional/Handlers/MigrationFetchSourceHandlerProcessTest.php.vortex/installer/tests/Functional/Handlers/MigrationHandlerProcessTest.php.vortex/installer/tests/Functional/PharTest.php.vortex/installer/tests/Unit/ConfigTest.php.vortex/installer/tests/Unit/Handlers/AbstractHandlerDiscoveryTestCase.php.vortex/installer/tests/Unit/Handlers/AbstractHandlerTypeTest.php.vortex/installer/tests/Unit/Handlers/DatabaseDownloadSourceHandlerDiscoveryTest.php.vortex/installer/tests/Unit/Handlers/DatabaseFetchSourceHandlerDiscoveryTest.php.vortex/installer/tests/Unit/Handlers/DatabaseImageHandlerDiscoveryTest.php.vortex/installer/tests/Unit/Handlers/HostingProjectNameHandlerDiscoveryTest.php.vortex/installer/tests/Unit/Handlers/HostingProviderHandlerDiscoveryTest.php.vortex/installer/tests/Unit/Handlers/MigrationFetchSourceHandlerDiscoveryTest.php.vortex/installer/tests/Unit/Handlers/MigrationHandlerDiscoveryTest.php.vortex/installer/tests/Unit/Handlers/MigrationImageHandlerDiscoveryTest.php.vortex/installer/tests/Unit/Handlers/ProvisionTypeHandlerDiscoveryTest.php.vortex/installer/tests/Unit/Schema/SchemaGeneratorTest.php.vortex/installer/tests/Unit/Schema/SchemaValidatorTest.php.vortex/installer/tests/Unit/Utils/FileManagerTest.php.vortex/installer/tests/Unit/Utils/OptionsResolverTest.php.vortex/tests/generate-vortex-dev-circleci.vortex/tests/phpunit/Functional/AhoyWorkflowTest.php.vortex/tests/phpunit/Functional/DockerComposeWorkflowTest.php.vortex/tests/phpunit/Traits/Subtests/SubtestAhoyTrait.php.vortex/tests/phpunit/Traits/SutTrait.php.vortex/tooling/composer.json.vortex/tooling/playground/try-s3-fetch.sh.vortex/tooling/src/download-db.vortex/tooling/src/download-db-container-registry.vortex/tooling/src/fetch-db.vortex/tooling/src/fetch-db-acquia.vortex/tooling/src/fetch-db-container-registry.vortex/tooling/src/fetch-db-ftp.vortex/tooling/src/fetch-db-lagoon.vortex/tooling/src/fetch-db-s3.vortex/tooling/src/fetch-db-url.vortex/tooling/tests/_helper.bash.vortex/tooling/tests/unit/download-db-container-registry.bats.vortex/tooling/tests/unit/download-db-ftp.bats.vortex/tooling/tests/unit/download-db-s3.bats.vortex/tooling/tests/unit/download-db-url.bats.vortex/tooling/tests/unit/download-db.bats.vortex/tooling/tests/unit/fetch-db-acquia.bats.vortex/tooling/tests/unit/fetch-db-container-registry.bats.vortex/tooling/tests/unit/fetch-db-ftp.bats.vortex/tooling/tests/unit/fetch-db-lagoon.bats.vortex/tooling/tests/unit/fetch-db-s3.bats.vortex/tooling/tests/unit/fetch-db-url.bats.vortex/tooling/tests/unit/fetch-db.batsAGENTS.mdREADME.dist.mdscripts/provision-20-migration.shscripts/vortex-tooling.sh
💤 Files with no reviewable changes (9)
- .vortex/tooling/tests/unit/download-db-container-registry.bats
- .vortex/tooling/tests/unit/download-db-s3.bats
- .vortex/tooling/src/download-db-container-registry
- .vortex/installer/tests/Functional/Handlers/DatabaseDownloadSourceHandlerProcessTest.php
- .vortex/installer/tests/Unit/Handlers/DatabaseDownloadSourceHandlerDiscoveryTest.php
- .vortex/tooling/tests/unit/download-db-ftp.bats
- .vortex/tooling/tests/unit/download-db.bats
- .vortex/tooling/tests/unit/download-db-url.bats
- .vortex/tooling/src/download-db
|
📖 Documentation preview for this pull request has been deployed to Netlify: https://6a3db482c05b0696573df724--vortex-docs.netlify.app This preview is rebuilt on every commit and is not the production documentation site. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2730 +/- ##
==========================================
- Coverage 86.67% 86.22% -0.45%
==========================================
Files 96 89 -7
Lines 4719 4560 -159
Branches 47 3 -44
==========================================
- Hits 4090 3932 -158
+ Misses 629 628 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Code coverage (threshold: 90%) Per-class coverage |
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
Member
Author
|
Code coverage (threshold: 90%) Per-class coverage |
AlexSkrypnyk
added
the
Needs review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2726
Summary
Renamed the
download-dbcommand, allVORTEX_DOWNLOAD_DB*variables, and the installer "download source" concept tofetch-db/VORTEX_FETCH_DB*/ "fetch source" end-to-end across the Vortex template. The primary Ahoy commands are nowfetch-dbandfetch-db2, withdownload-db/download-db2retained as muscle-memory aliases. All six tooling driver scripts, their BATS test suites, ~130 installer fixtures,variables.mdx, and every prose reference across.env, CI configs,.lagoon.yml, README, docs, and AGENTS.md were updated in lockstep.Changes
Command + drivers
.vortex/tooling/src/download-dband six driver scripts (-acquia,-container-registry,-ftp,-lagoon,-s3,-url) tofetch-dbequivalents.fetch-db/fetch-db2are now the canonical Ahoy commands;download-db/download-db2remain as aliases.Variables + semaphore
VORTEX_DOWNLOAD_DB*->VORTEX_FETCH_DB*across.env,.env.local.example,.lagoon.yml, CI configs, tooling scripts, and all installer fixtures./tmp/download-db-success->/tmp/fetch-db-success.VORTEX_SSH_PREFIX_DOWNLOADLagoon variable renamed toVORTEX_SSH_PREFIX_FETCH.Installer "download source" concept
DatabaseDownloadSource/MigrationDownloadSource->DatabaseFetchSource/MigrationFetchSource.database_download_source/migration_download_source->*_fetch_source.DB_DOWNLOAD_SOURCE_*/MIGRATION_DB_DOWNLOAD_SOURCE_*->DB_FETCH_SOURCE_*/MIGRATION_DB_FETCH_SOURCE_*.VORTEX_INSTALLER_IS_DEMO_DB_DOWNLOAD_SKIP->VORTEX_INSTALLER_IS_DEMO_DB_FETCH_SKIP.db_download_source_*/migration_download_source_*->db_fetch_source_*/migration_fetch_source_*(~130 fixtures, 139 snapshot scenarios).Prose + docs
.ahoy.ymlusage strings, CI step names,.lagoon.ymltask labels,README.dist.md,AGENTS.md,.envcomments, and.vortex/docs/.variables.mdxregenerated viaahoy update-docs.Test robustness
InstallCommandTestnow sets the demo-database fetch skip flag to prevent a leakedVORTEX_FETCH_DB_URLfrom causing failures.setUpclears the renamedVORTEX_FETCHenv prefix, preventing URL leakage between tests.Intentional keeps (not renamed)
pull-dbcommand's "Download database image" description - a different command, unrelated to this rename._code-lifecycle.mdxASCII diagram label - kept to preserve box alignment.releases/download/GitHub URL paths - GitHub infrastructure, not Vortex terminology.actions/download,getEnvironmentsDatabaseDownloadBackup) - third-party API identifiers.Follow-up
VORTEX_FETCH_DB_SSH_PRIVATE_KEYand variableVORTEX_FETCH_DB_SSH_KNOWN_HOSTSmust be manually renamed in repository settings for the Lagoon-over-SSH path (the step is gated on the secret being non-empty, so CI does not break until the secret is used).ahoy update-videos installer.Before / After
Summary by CodeRabbit
New Features
fetch-dbandfetch-db2commands for retrieving database dumps, including support for fresh fetches and indexed secondary databases.Bug Fixes
Documentation