Moved 'drupal/sdc_devel' to 'require' section.#2714
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (26)
📒 Files selected for processing (3)
💤 Files with no reviewable changes (1)
WalkthroughMoves ChangesSDC devel dependency relocation
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
Code coverage (threshold: 90%) Per-class coverage |
This comment has been minimized.
This comment has been minimized.
|
📖 Documentation preview for this pull request has been deployed to Netlify: https://6a3c8752b62618b7fa4ce3f8--vortex-docs.netlify.app This preview is rebuilt on every commit and is not the production documentation site. |
This comment has been minimized.
This comment has been minimized.
1 similar comment
|
Code coverage (threshold: 90%) Per-class coverage |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2714 +/- ##
==========================================
- Coverage 86.67% 86.22% -0.45%
==========================================
Files 96 89 -7
Lines 4719 4560 -159
Branches 47 3 -44
==========================================
- Hits 4090 3932 -158
+ Misses 629 628 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Summary
Moved
drupal/sdc_develfromrequire-devintorequirein the root templatecomposer.jsonso the Single Directory Components development module ships as a runtime dependency rather than a dev-only one. Documentation and an installer test comment were updated to match, and the installer/test fixtures were regenerated.Changes
composer.json: moveddrupal/sdc_develintorequire(alphabetically betweendrupal/robotstxtanddrupal/search_api) and removed it fromrequire-dev.composer.lockis gitignored in this repo, so there is no lock change..vortex/docs/content/drupal/composer-json.mdx: removed thedrupal/sdc_develbullet from therequire-devsection; therequiresection already describes Drupal modules generically, so no per-module bullet is added there..vortex/installer/tests/Unit/Handlers/ModulesHandlerDiscoveryTest.php: reworded the comment that calledsdc_devela dev-onlyrequire-devmodule; the stub still places one module inrequire-devto verify discovery reads bothrequireandrequire-dev..vortex/installerhandler_processcomposer.jsonfixtures and the baseline viaahoy update-snapshots(committed separately).Screenshots
N/A
Before / After
Summary by CodeRabbit
New Features
Documentation