Skip to content

Moved 'drupal/sdc_devel' to 'require' section.#2714

Merged
AlexSkrypnyk merged 2 commits into
mainfrom
feature/sdc-devel-require
Jun 25, 2026
Merged

Moved 'drupal/sdc_devel' to 'require' section.#2714
AlexSkrypnyk merged 2 commits into
mainfrom
feature/sdc-devel-require

Conversation

@AlexSkrypnyk

@AlexSkrypnyk AlexSkrypnyk commented Jun 25, 2026

Copy link
Copy Markdown
Member

Summary

Moved drupal/sdc_devel from require-dev into require in the root template composer.json so the Single Directory Components development module ships as a runtime dependency rather than a dev-only one. Documentation and an installer test comment were updated to match, and the installer/test fixtures were regenerated.

Changes

  • composer.json: moved drupal/sdc_devel into require (alphabetically between drupal/robotstxt and drupal/search_api) and removed it from require-dev. composer.lock is gitignored in this repo, so there is no lock change.
  • .vortex/docs/content/drupal/composer-json.mdx: removed the drupal/sdc_devel bullet from the require-dev section; the require section already describes Drupal modules generically, so no per-module bullet is added there.
  • .vortex/installer/tests/Unit/Handlers/ModulesHandlerDiscoveryTest.php: reworded the comment that called sdc_devel a dev-only require-dev module; the stub still places one module in require-dev to verify discovery reads both require and require-dev.
  • Regenerated the .vortex/installer handler_process composer.json fixtures and the baseline via ahoy update-snapshots (committed separately).

Screenshots

N/A

Before / After

composer.json (root template)

  BEFORE                              AFTER
  require:                            require:
    ... drupal/robotstxt                ... drupal/robotstxt
    drupal/search_api                   drupal/sdc_devel   <-- moved here
    ...                                 drupal/search_api
  require-dev:                          ...
    ... drupal/drupal-extension       require-dev:
    drupal/sdc_devel   <-- removed      ... drupal/drupal-extension
    ergebnis/composer-normalize         ergebnis/composer-normalize

Summary by CodeRabbit

  • New Features

    • Moved a previously development-only package into the main dependency set, making its functionality available in standard installs.
  • Documentation

    • Updated setup guidance to reflect the current dependency list.
    • Clarified test notes around module discovery behavior.

@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: bebdab66-ed69-4209-b6b6-a4a1b667ae31

📥 Commits

Reviewing files that changed from the base of the PR and between b845ffc and cf030a4.

⛔ Files ignored due to path filters (26)
  • .vortex/installer/tests/Fixtures/handler_process/_baseline/composer.json is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/custom_modules_search_without_solr/composer.json is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/modules_no_reroute_email/composer.json is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/modules_no_robotstxt/composer.json is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/modules_no_sdc_devel/composer.json is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/modules_no_seckit/composer.json is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/modules_no_seckit_shield_stage_file_proxy/composer.json is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/modules_no_shield/composer.json is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/modules_no_stage_file_proxy/composer.json is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/modules_no_testmode/composer.json is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/modules_no_xmlsitemap/composer.json is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/modules_none/composer.json is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/non_interactive_config_file/composer.json is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/services_no_redis/composer.json is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/services_no_solr/composer.json is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/services_none/composer.json is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/starter_drupal_cms_profile/composer.json is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/tools_groups_no_be_lint/composer.json is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/tools_groups_no_be_lint_circleci/composer.json is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/tools_groups_no_be_tests/composer.json is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/tools_groups_no_be_tests_circleci/composer.json is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/tools_no_behat/composer.json is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/tools_no_behat_circleci/composer.json is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/tools_no_phpcs/composer.json is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/tools_no_phpcs_circleci/composer.json is excluded by !.vortex/installer/tests/Fixtures/**
  • .vortex/installer/tests/Fixtures/handler_process/tools_none/composer.json is excluded by !.vortex/installer/tests/Fixtures/**
📒 Files selected for processing (3)
  • .vortex/docs/content/drupal/composer-json.mdx
  • .vortex/installer/tests/Unit/Handlers/ModulesHandlerDiscoveryTest.php
  • composer.json
💤 Files with no reviewable changes (1)
  • .vortex/docs/content/drupal/composer-json.mdx

Walkthrough

Moves drupal/sdc_devel from require-dev to require in composer.json, removes its old documentation entry, and updates a module discovery test comment to describe stubbing from require-dev.

Changes

SDC devel dependency relocation

Layer / File(s) Summary
Dependency move and reference updates
composer.json, .vortex/docs/content/drupal/composer-json.mdx, .vortex/installer/tests/Unit/Handlers/ModulesHandlerDiscoveryTest.php
drupal/sdc_devel is added to require, removed from require-dev, and the composer docs and module discovery test comment are updated to match the new dependency placement and test setup.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • drevops/vortex#2671: Also moves drupal/sdc_devel between dependency sections and updates the matching composer docs.
  • drevops/vortex#2679: Touches ModulesHandlerDiscoveryTest::dataProviderRunPrompts() and the same module discovery coverage around dependency sources.
  • drevops/vortex#2687: Modifies the drupal/sdc_devel composer declaration in the same dependency block.

Suggested labels

Dependencies

Poem

🐰 I hop through composer.json at dawn,
with sdc_devel now in require drawn.
The docs nibble old notes away,
while tests watch both paths in play,
and the carrot truth stays crisp and strong.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: moving drupal/sdc_devel into the require section.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/sdc-devel-require

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

Code coverage (threshold: 90%)

  Classes: 100.00% (1/1)
  Methods: 100.00% (2/2)
  Lines:   98.58% (208/211)
Per-class coverage
Drupal\ys_demo\Plugin\Block\CounterBlock
  Methods: 100.00% ( 2/ 2)   Lines: 100.00% ( 10/ 10)

@AlexSkrypnyk AlexSkrypnyk moved this from BACKLOG to In progress in Vortex 1.x Jun 25, 2026
@AlexSkrypnyk AlexSkrypnyk added this to the 1.40.0 milestone Jun 25, 2026
@AlexSkrypnyk

This comment has been minimized.

@github-actions

Copy link
Copy Markdown

📖 Documentation preview for this pull request has been deployed to Netlify:

https://6a3c8752b62618b7fa4ce3f8--vortex-docs.netlify.app

This preview is rebuilt on every commit and is not the production documentation site.

@AlexSkrypnyk

This comment has been minimized.

1 similar comment
@AlexSkrypnyk

Copy link
Copy Markdown
Member Author

Code coverage (threshold: 90%)

  Classes: 100.00% (1/1)
  Methods: 100.00% (2/2)
  Lines:   98.58% (208/211)
Per-class coverage
Drupal\ys_demo\Plugin\Block\CounterBlock
  Methods: 100.00% ( 2/ 2)   Lines: 100.00% ( 10/ 10)

@codecov

codecov Bot commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.22%. Comparing base (b845ffc) to head (cf030a4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2714      +/-   ##
==========================================
- Coverage   86.67%   86.22%   -0.45%     
==========================================
  Files          96       89       -7     
  Lines        4719     4560     -159     
  Branches       47        3      -44     
==========================================
- Hits         4090     3932     -158     
+ Misses        629      628       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AlexSkrypnyk AlexSkrypnyk added the Needs review Pull request needs a review from assigned developers label Jun 25, 2026
@AlexSkrypnyk AlexSkrypnyk merged commit 36ab224 into main Jun 25, 2026
34 checks passed
@AlexSkrypnyk AlexSkrypnyk deleted the feature/sdc-devel-require branch June 25, 2026 01:52
@github-project-automation github-project-automation Bot moved this from In progress to Release queue in Vortex 1.x Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs review Pull request needs a review from assigned developers

Projects

Status: Release queue

Development

Successfully merging this pull request may close these issues.

1 participant