Conversation
…our (#1287) * Add user override for default stage direction background and text colour Adds two new nullable columns to UserSettings (default_sd_background_colour, default_sd_text_colour) so users can personalise the fallback appearance applied to unstyled stage direction lines. Includes UI in both Vue 3 and Vue 2 clients, an Alembic migration, E2E coverage, and updated user documentation. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Fix ruff import ordering in migration file Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Expand E2E coverage for default stage direction style feature Adds full end-to-end coverage: default preview colour assertion (verifies darkslateblue fallback), WS sync round-trip (preview updates after PATCH), persistence across page reload (GET /api/v1/user/settings), text colour override path, and Reset to Default restoring the fallback. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Fix default stage direction modal colours and always-show Reset button - Fix background colour picker initialising to #2f4f4f (darkslategray) instead of #483d8b (darkslateblue) when no override is set - Reset to Default button is now always visible; disabled when there is no override to clear rather than hidden with v-if - Update E2E assertions from toBeVisible/not.toBeVisible to toBeEnabled/toBeDisabled to match the new always-visible button Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
#1290) The Vue 3 migration reimplemented the walk-back-past-cut-lines logic in useScriptNavigation.ts using a single-page Array.indexOf lookup instead of the page-crossing walk the legacy Vue 2 client used. When that walk reached the first line of a page while still skipping cut/spacing lines, it gave up and treated the previous line as null, causing the heading to spuriously re-render even though the true previous line one page back was the same act/scene. The same bug was independently duplicated in the needsIntervalBanner computed in both live-view components. Adds a shared getPreviousLineAcrossPages helper (mirroring V2's getPreviousLineForIndex) and uses it in all four affected call sites.
* Add current cue footer to live show view Shows the last cue passed for every cue type in a footer below the script pane, so the current cueing position stays visible without needing the script's cue column in frame. Toggleable per user from User Settings. Fixes the live script pane's JS-computed height so it accounts for the new footer instead of claiming the full viewport and pushing it off-screen. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * Port current cue footer to legacy Vue 2 client for feature parity Mirrors the client-v3 implementation: LINE_ORDER_INDEX/ORDERED_CUE_ENTRIES/ LAST_CUE_PER_TYPE_AT Vuex getters, a CurrentCueFooter.vue component reusing cueDisplayMixin, the same computeContentSize()/ResizeObserver fix in ScriptViewPane.vue, the same follower currentLineOnPage gap fix, and the toggle added to the existing User Settings form. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
|
github-actions
Bot
added
documentation
Client V3 Test Results39 tests 39 ✅ 0s ⏱️ Results for commit fa0adf2. |
Client Test Results132 tests 132 ✅ 0s ⏱️ Results for commit fa0adf2. |
Playwright E2E Results (firefox)221 tests 221 ✅ 2m 15s ⏱️ Results for commit fa0adf2. |
Python Test Results 1 files 1 suites 2m 15s ⏱️ Results for commit fa0adf2. |
Playwright E2E Results (chromium)221 tests 221 ✅ 2m 18s ⏱️ Results for commit fa0adf2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.