Skip to content

Live verification default for AD scoring - #636

Merged
mkultraWasHere merged 6 commits into
mainfrom
fix/scoring
Oct 28, 2026
Merged

mkultraWasHere merged 6 commits into
mainfrom
fix/scoring

Conversation

@mkultraWasHere

Copy link
Copy Markdown
Contributor

Changed

  • /score guidance now documents the range-aware live default in agent instructions and console help.

Breaking

  • Console-agent /score now live-verifies built-in Active Directory results by default; pass --live-verify=false to retain static scoring.

mkultraWasHere and others added 2 commits October 28, 2026 15:48
Make full Active Directory scoring deterministic for console agents instead
of relying on the model to discover the live verification flag.

Co-Authored-By: Codex <noreply@anthropic.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the change making live verification the default for built-in Active Directory /score commands.

No open issues 🎉

What changed in this PR

Makes live verification the console-agent default for built-in Active Directory /score commands, while preserving explicit static scoring with --live-verify=false and leaving other range scorers unchanged.

Changes:

  • Applies range-aware defaults before agent commands reach the runner.
  • Documents the default and static-scoring opt-out in agent guidance and updates console help.
  • Adds tests for default injection, explicit opt-out, and range-specific behavior.
File Description
console/​frontend/​src/​help.ts Updates /score help to mention the built-in AD live default.
console/​backend/​tests/​test_commands.py Tests range-aware defaults and agent instructions.
console/​backend/​tests/​test_chat.py Tests live defaults and static opt-out through the agent tool.
console/​backend/​prompts/​score.md Documents the live default and explicit static-scoring option.
console/​backend/​commands.py Adds shared guidance and range-aware argument defaults.
console/​backend/​agent.py Passes capabilities into the tool and applies and exposes command defaults.

Review effort: Balanced

mkultraWasHere and others added 4 commits October 28, 2026 16:10
Keep executable defaults independent from their human-facing guidance while
co-locating both with the command they govern.

Co-Authored-By: Codex <noreply@anthropic.com>
Exercise the production helper with empty guidance so prose changes cannot
silently disable the live-verification default.

Co-Authored-By: Codex <noreply@anthropic.com>
Keep command policy guidance in the system prompt only and derive runnable commands directly from the capability snapshot.

Co-Authored-By: Codex <noreply@anthropic.com>
Verify the agent factory gives its prompt and command tool the same capability-derived command set.

Co-Authored-By: Codex <noreply@anthropic.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues block the change making live verification the default for built-in Active Directory scoring.

No open issues 🎉

Review effort: Balanced

@mkultraWasHere
mkultraWasHere added this pull request to the merge queue Oct 28, 2026
Merged via the queue into main with commit 389118e Oct 28, 2026
10 checks passed
@mkultraWasHere
mkultraWasHere deleted the fix/scoring branch October 28, 2026 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants