Skip to content

Raise PlyHeaderParseError instead of UnicodeDecodeError on a non-ASCII header #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dranjan merged 1 commit into from
Oct 15, 2026
+12 −1
Merged

Raise PlyHeaderParseError instead of UnicodeDecodeError on a non-ASCII header #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion plyfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1298,7 +1298,11 @@ def _decode(s):
"""
if isinstance(s, str):
return s
return s.decode('ascii')
try:
return s.decode('ascii')
except UnicodeDecodeError:
raise PlyHeaderParseError(
"header contains non-ASCII characters")

def __iter__(self):
"""
Expand Down
7 changes: 7 additions & 0 deletions test/test_plyfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -802,6 +802,13 @@ def test_header_parse_error(s, line):
assert e.exc_val.line == line


def test_header_non_ascii_bytes():
# a non-PLY binary file (e.g. a PNG) should raise PlyHeaderParseError,
# not a raw UnicodeDecodeError from the non-ASCII header bytes
with Raises(PlyHeaderParseError):
PlyData.read(BytesIO(b'\x89PNG\r\n\x1a\n' + b'\x00' * 40))


invalid_arrays = [
numpy.zeros((2, 2)),
numpy.array([(0, (0, 0))],
Expand Down
Loading