pop3 proxy: Sanitize input username/password#1559
Conversation
| | \`connection_limit\` | Client reached [[setting,mail_max_userip_connections]] limit. | | ||
| | \`internal_failure\` | Internal failure. The error log has more details. | | ||
| | \`invalid_base64\` | Client sent invalid base64 in SASL response. | | ||
| | \`invalid_credentials\` | The credentials are not valid (as ill specified, not as not matching). | |
There was a problem hiding this comment.
I think this is more succinct as "The credential syntax is not valid." That clearly describes this as a technical issue, not a user checking problem.
| | \`cleartext_auth_disabled\` | Cleartext authentication is not enabled, use TLS. | | ||
| | \`anonymous_auth_disabled\` | Anonymous authentication is not enabled. | | ||
| | \`auth_nologin_referral\` | Authentication returned auth referral to redirect the client to another server. This is normally configured to be sent only when the client is a Dovecot proxy, which handles the redirection. For example site1-proxy1 connects to site2-proxy2, and site2-proxy2 decides to ask site1-proxy1 to connect to site3 instead. See also \`proxy_dest_redirected\` code, which is used when the proxy itself does the redirection. | | ||
| | \`invalid_credentials\` | The credentials are not valid (as ill specified, not as not matching). This normally happens when credentials (user/pass) containing control codes need to be transferred unencoded through cleartext protocols. | |
There was a problem hiding this comment.
Same as above: replace first sentence with "The credential syntax is not valid." The rest is fine.
There was a problem hiding this comment.
Thing is, those credentials's syntax is not generally invalid, they happen to be invalid on the specific channel/protocol where they are attempted to be used. What do you think about ""The credentias are not usable "" ?
There was a problem hiding this comment.
"not usable" doesn't give a clue as to what the problem is. Maybe: "The credentials are invalid due to formatting issues, not a mismatch." or "The credentials are invalid due to improper formatting."
|
Also, fix typo in commit message: "coden" -> "code" |
2 participants
No description provided.