Skip to content

Optimize transaction cleanup to prevent memory leaks #1790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wificlub-coder wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −0
Open

Optimize transaction cleanup to prevent memory leaks #1790

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/DotNetCore.CAP/Internal/ICapPublisher.Default.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,12 @@ public ICapTransaction? Transaction
get => _asyncLocal.Value?.Transaction;
set
{
if (value == null)
{
// Clear the CapTransactionHolder held in the ExecutionContext to avoid long-term reference retention.
_asyncLocal.Value = null;
return;
}
_asyncLocal.Value ??= new CapTransactionHolder();
_asyncLocal.Value.Transaction = value;
}
Expand Down Expand Up @@ -184,6 +190,11 @@ private async Task PublishInternalAsync<T>(string name, T? value, IDictionary<st

throw;
}
finally
{
// Whether successful or exceptional, explicitly clear the transaction reference in the current context after the release is completed.
Transaction = null;
}
}

#region tracing
Expand Down