feat(Card): remove --bs-card-body-color variable - #8455
Merged
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideReplaces the unsupported File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![bb-auto[bot]](https://avatars.githubusercontent.com/in/287253?s=60&v=4){kind=small}
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="src/BootstrapBlazor/Components/Card/Card.razor.scss" line_range="9" />
<code_context>
--bb-card-title-margin-left: #{$bb-card-title-margin-left};
--bb-card-header-tag-height: #{$bb-card-header-tag-height};
--bs-card-title-spacer-y: #{$bb-card-title-spacer-y};
+ overflow: hidden;
}
</code_context>
<issue_to_address>
**issue (broader_impact):** `overflow: hidden` clips absolutely positioned descendants that extend beyond the card border, such as dropdown menus, popovers, and other overlays rendered inside a card. Those controls become partially or completely inaccessible when their popup crosses the card boundary.
**Triggers:** When a card contains a dropdown, popover, tooltip, or other positioned child whose rendered area extends outside the card.
**Suggested fix:** Apply the overflow clipping only to the card sections that need rounded-corner clipping, or use a wrapper for the card background/border so positioned descendants remain visible.
```suggestion
```
</issue_to_address>Sourcery assessment
Approval pending. 1 finding to address first.
Blocking findings: src/BootstrapBlazor/Components/Card/Card.razor.scss:9
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8455 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 776 776
Lines 35069 35069
=========================================
Hits 35069 35069
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #8454
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Replace the card body color variable with Bootstrap’s standard card styling variables and improve card body appearance consistency.
Bug Fixes:
Enhancements: