Pin the MongoDB test container to 8.0.4 - #3
Merged
Merged
Conversation
mongo:8 floats to the newest 8.x, so the image the integration tests run against could change under a build that touched nothing — a fixture failing on a machine where the tag had moved, and passing on one where it had not. This leaves Mongo as the only fixture naming an exact image. PostgreSqlFixture still asks for postgres:17-alpine and SqlServerFixture for mcr.microsoft.com/mssql/server:2022-latest, both of which float the same way and are worth pinning on the same reasoning. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
mongo:8floats to the newest 8.x, so the image the integration tests run against can change under a build that touched nothing — a fixture failing on a machine where the tag had moved and passing on one where it had not.Scope
This leaves Mongo as the only fixture naming an exact image. The other two float the same way and are worth pinning on identical reasoning:
MongoDbFixturemongo:8.0.4PostgreSqlFixturepostgres:17-alpineSqlServerFixturemcr.microsoft.com/mssql/server:2022-latestlatestLeft out of this PR to keep it to the change that was already sitting in the working tree. Happy to follow up.
Verified
The 142 integration tests were run locally against a real container on
mongo:8.0.4and pass.🤖 Generated with Claude Code