Skip to content

Derive the preview version from a release base, not a prerelease tag #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sadeqabuhattem merged 1 commit into from
Sep 10, 2026
Merged

Derive the preview version from a release base, not a prerelease tag #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,9 +262,22 @@ jobs:
# tags in the repository the fallback never fired, BASE came out empty, and the
# version became "-preview.N" — which pack rejects deep inside MSBuild. Test the
# value, not the exit status.
BASE=$(git describe --tags --abbrev=0 2>/dev/null | sed 's/^v//' || true)
#
# The newest tag is itself usually a prerelease (v1.0.0-preview.1), so strip any
# -prerelease / +build suffix as well as the leading v and keep MAJOR.MINOR.PATCH.
# Appending -preview.N to a base that already carries a prerelease suffix yields
# 1.0.0-preview.1-preview.N: valid enough SemVer to pass the check below, and wrong
# enough to publish under a name nobody is looking for.
BASE=$(git describe --tags --abbrev=0 2>/dev/null | sed -E 's/^v//; s/[-+].*$//' || true)
[[ -n "${BASE}" ]] || BASE="1.0.0"

# Anything the strip did not reduce to MAJOR.MINOR.PATCH (a v1.0 tag, say) would
# only surface later as an opaque pack failure.
if [[ ! "${BASE}" =~ ^[0-9]+\.[0-9]+\.[0-9]+$ ]]; then
echo "::error::Derived base version '${BASE}' is not MAJOR.MINOR.PATCH"
exit 1
fi

if [[ "${GITHUB_REF}" == refs/heads/main ]]; then
VERSION="${BASE}-preview.${{ github.run_number }}"
else
Expand Down
Loading