Repository navigation
Upgrade Auditing to 1.0.0-preview.3 - #6
Merged
Merged
Conversation
Auditing.Core, .EntityFrameworkCore and .API move from preview.2 to preview.3. No code changes: preview.3 only adds API, and its fixes are inside the save interceptor. With Auditing registered after MultiLingual, one context and HiLo keys, none of its behaviour changes reach this sample. What changes is the stated reason for the HiLo keys. Since preview.3 of both libraries, Auditing's nested save is safe beside MultiLingual's interceptor in either order, so HiLo no longer keeps the two apart; it is kept because a creation in one save is simpler, and dropping it would need a data migration. DependencyInjection.cs, CategoryConfiguration.cs and README section 6 now say so. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Moves
DotNetBoost.Auditing.Core,.EntityFrameworkCoreand.APIfrom1.0.0-preview.2to1.0.0-preview.3, andcorrects the comments that gave the old reason for the HiLo keys.
Why no code changes
Preview.3 (changelog)
only adds API, and its fixes are inside the save interceptor, which ships in the package. None of
its behaviour changes reach this sample:
UseAuditing(sp)is registered afterUseMultiLingual(sp), and no other interceptor follows it,so the commit stays where it was.
AppDbContextis the only context, so "the context being saved" is always the registered one.IAuditStoreorIAuditObserver.CategoryandProducttake HiLo keys, so no creation is deferred.The HiLo keys stay; their stated reason changes
Since preview.3 of both libraries, Auditing's nested save is safe beside MultiLingual's interceptor
in either registration order. HiLo no longer keeps the two apart. It is kept because a creation in
one save is simpler, and dropping it would need a data migration. Updated:
Infrastructure/DependencyInjection.cs;CategoryConfiguration.cs;Directory.Packages.props.Verified locally, against the published packages (
-p:UseLocalDotNetBoost=false)dotnet restore --force-evaluate(fresh vulnerability data): clean. The assets file resolvesAuditing
1.0.0-preview.3.mainalready has.DotNetBoostSample.Tests: 163 of 163 pass.🤖 Generated with Claude Code