Repository navigation
Move SqlClient to 6.1.8, and drop the Pkcs pin it no longer needs - #3
Merged
Merged
Conversation
6.1.8 brings in System.Security.Cryptography.Pkcs 9.0.21, past both advisories the pin was there for, so NuGet audit stays clean without it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Moves
Microsoft.Data.SqlClientfrom 6.1.6 to 6.1.8, and removes theSystem.Security.Cryptography.Pkcspin that 6.1.6 needed.Why
SqlClient 6.1.6 brought in Pkcs 9.0.11, which has two advisories
(GHSA-846f-f764-76mx, GHSA-2fmv-rv2c-59x7), so
Directory.Packages.propspinned Pkcs forward to10.0.13. SqlClient 6.1.8 brings in Pkcs 9.0.21, past both, so the pin has nothing left to do.
SqlClient is referenced only by the integration tests (the Dapper store's SQL Server suite). No
shipped package depends on it.
Verified locally
dotnet restore --force-evaluate(fresh vulnerability data): clean.dotnet list package --vulnerable --include-transitivefinds none.and net10.0), IntegrationTests 202 against PostgreSQL, SQL Server and MongoDB. All pass.
🤖 Generated with Claude Code