Fix ToolStripDropDownMenu scrolling when items are unavailable#14631
Open
SweathaBharathi wants to merge 3 commits into
Open
Fix ToolStripDropDownMenu scrolling when items are unavailable#14631SweathaBharathi wants to merge 3 commits into
SweathaBharathi wants to merge 3 commits into
Conversation
…MenuItem item Available=false
…MenuItem item Available=false
…MenuItem item Available=false
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7635
Proposed changes
ToolStripDropDownMenu.ScrollInternal(bool up)to skip items that are not available when calculating the scroll target and scroll delta.Itemscollection.Available = false), including empty space at the top or bottom, overscrolling at the end of the list, and looping behavior when scrolling upward.Customer Impact
ContextMenuStrip/ToolStripDropDownMenuscrolling when some items are hidden viaAvailable = false, which previously could produce empty space at the top or bottom while scrolling.Regression?
Risk
Screenshots
Before
After
Test methodology
ContextMenuStripwithMaximumSizeset small enough to enable scrolling and with one item added withAvailable = falsebefore being inserted into the menu.Accessibility testing
Test environment(s)
Microsoft Reviewers: Open in CodeFlow