Update TemplateEngine and PR builds from Ubuntu 20.04 to 22.04 and fix Windows image references#53012
Update TemplateEngine and PR builds from Ubuntu 20.04 to 22.04 and fix Windows image references#53012Copilot wants to merge 7 commits intorelease/8.0.1xxfrom
Conversation
Co-authored-by: marcpopMSFT <12663534+marcpopMSFT@users.noreply.github.com>
|
@copilot Can you update to 24.04 instead? Can you check the .PR yaml to ensure we aren't on any old versions for PRs as well. |
Co-authored-by: marcpopMSFT <12663534+marcpopMSFT@users.noreply.github.com>
Updated to Ubuntu 24.04 in commit 46d2072. Changes include: eng/template-engine.yml: Ubuntu_20_04_TemplateEngine → Ubuntu_24_04_TemplateEngine with 1es-ubuntu-2404-open/1es-ubuntu-2404 images .vsts-pr.yml: Ubuntu_22_04 → Ubuntu_24_04 with ubuntu-24.04/build.ubuntu.2404.amd64 images All helix queues updated to ubuntu.2404/Ubuntu.2404 to match. |
|
@agocke a lot of the downlevel (3.1 or older) linker tests failed with the following message: I assume your recommendation is just to disable these tests. We have to update the ubuntu version as 2004 is no longer supported in the lab but it appears targeting downlevel on newer ubuntu for linker is not supported. I think I recall us having this conversation before when we updated the ubuntu version in other repos. |
|
@copilot Update |
Co-authored-by: NikolaMilosavljevic <9423618+NikolaMilosavljevic@users.noreply.github.com>
Fixed in commit 1c2b1e8. Updated ImageOverride references from |
|
@copilot - there are no 24.04 build images, we need to use 22.04. Update pool images, i.e. |
…4.04 Co-authored-by: NikolaMilosavljevic <9423618+NikolaMilosavljevic@users.noreply.github.com>
Fixed in commit 327e7fc. Reverted pool images to Ubuntu 22.04: eng/template-engine.yml: agentOs Ubuntu_22_04_TemplateEngine with 1es-ubuntu-2204-open/1es-ubuntu-2204 .vsts-pr.yml: agentOs Ubuntu_22_04 with ubuntu-22.04/build.ubuntu.2204.amd64 Helix queues remain at ubuntu.2404/Ubuntu.2404 as requested. |
|
@copilot - |
…s-ubuntu-2204-open Co-authored-by: NikolaMilosavljevic <9423618+NikolaMilosavljevic@users.noreply.github.com>
|
@copilot update helix images to use ubuntu 22.04 instead of 24.04 |
Co-authored-by: NikolaMilosavljevic <9423618+NikolaMilosavljevic@users.noreply.github.com>
Fixed in commit 73a289c. Updated Helix queues to Ubuntu 22.04: eng/template-engine.yml: ubuntu.2404 → ubuntu.2204, Ubuntu.2404.Amd64 → Ubuntu.2204.Amd64 .vsts-pr.yml: ubuntu.2404.amd64.open → ubuntu.2204.amd64.open, Ubuntu.2404.Amd64 → Ubuntu.2204.Amd64 |
The
1es-ubuntu-2004-openimage is no longer available inNetCore-Svc-Publicpool, causing TemplateEngine PR builds to fail. Updated to Ubuntu 22.04 for both build pool images and Helix test queues. Also fixed Windows image references to use stable VS2022 images.Changes
Updated
eng/template-engine.yml:Ubuntu_20_04_TemplateEngine→Ubuntu_22_04_TemplateEngine1es-ubuntu-2004-open→build.ubuntu.2204.amd64.open(public),1es-ubuntu-2004→build.ubuntu.2204.amd64(internal)ubuntu.2004.amd64.open→ubuntu.2204.amd64.openandUbuntu.2004.Amd64→Ubuntu.2204.Amd64windows.vs2022preview.amd64[-open]→windows.vs2022.amd64[-open](removed preview)Updated
.vsts-pr.yml:Ubuntu_22_04ubuntu-22.04/build.ubuntu.2204.amd64ubuntu.2404.amd64.open→ubuntu.2204.amd64.openandUbuntu.2404.Amd64→Ubuntu.2204.Amd64These changes use Ubuntu 22.04 consistently for both build pool images (where code is built) and Helix test queues (where tests are executed), with correct image names (
build.ubuntu.2204.amd64.openfor public builds,build.ubuntu.2204.amd64for internal builds).✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.