[release/11.0] Fix System.Text.Json source-generated unsafe accessors - #133886
Merged
Merged
Conversation
Fixes a number of codegen issues related to the source generator's handling of newly introduced unsafe accessors. To be backported to .NET 11. Fixes #133369. Fixes #133423. Fixes #133592. --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 2af8f83f-b01f-4ae3-b171-750c75bfde9e
|
Azure Pipelines: Successfully started running 4 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-text-json |
eiriktsarpalis
added
the
Servicing-consider
svick
approved these changes
Sep 14, 2026
This was referenced Sep 14, 2026
Open
artl93
approved these changes
Sep 14, 2026
artl93
left a comment
artl93
left a comment
Member
There was a problem hiding this comment.
regression. customer reported. approved.
Clean build analysis required before merge.
artl93
added
Servicing-approved
Member
|
/ba-g test failures are unrelated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #133599 to release/11.0
/cc @eiriktsarpalis
Customer Impact
Address two closely related customer reported issues:
Regression
#124650 introduced unsafe accessor suppor in .NET 11.
Testing
Added comprehensive testing covering the impacted corner cases. Enabled unsafe v2 in the STJ test projects to ensure it is being appropriately dogfed.
Risk
Medium. The fix involves nontrivial changes to the source generator emitter.