[release/11.0] Remove RCPC2 from the optimistic set on arm64 - #133701
Open
github-actions[bot] wants to merge 1 commit into
Open
github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Testing on android (dotnet/android#12722) showed that older devices don't have rcpc2 instruction set available which leads to significant r2r code rejection. This is a simpler, cross platform fix for the issue, compared to exposing knobs to tweak the optimistic set (#133514) and have dotnet/android use them. --------- Co-authored-by: Jan Kotas <jkotas@microsoft.com>
github-actions
Bot
requested a review
from MichalStrehovsky
as a code owner
September 11, 2026 15:18
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
Contributor
|
Tagging subscribers to this area: @dotnet/crossgen-contrib |
BrzVlad
approved these changes
Sep 11, 2026
jkotas
approved these changes
Sep 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #133576 to release/11.0
/cc @BrzVlad
Customer Impact
When this instruction set is included in the optimistic set, a significant amount of methods from ready to run are rejected on older devices (just a few years old), which leads to startup slowdown by around 10% on android. On Android, CoreCLR is already slightly behind Mono on startup, so this can give us a much needed boost on a significant amount of devices.
Regression
The fix itself is not for a regression, but users can experience worse perf without this fix, compared to previous mono based .net android.
Testing
Impact of removing this instruction set from the optimistic set was tested on multiple devices, with more detailed information available in dotnet/android#12722
Risk
Low. This simply removes a fairly new instruction set from the optimistic set on r2r.