Flush Crossgen2 R2R output stream before generating native PDB by Copilot · Pull Request #131607 · dotnet/runtime

Copilot · 2026-07-30T18:09:55Z

Crossgen2-generated native PDBs (*.ni.pdb) had an all-zero PDB-info GUID after the migration from R2RPEBuilder to PEObjectWriter, so the PDB could not satisfy the DLL's symbol-server lookup key and msdl symbol lookup failed for .NET 11 preview SDK R2R symbols.

Root cause

In ReadyToRunObjectWriter.EmitReadyToRunObjects, the output FileStream was declared with a method-scoped using, so it stayed open while SymbolFileBuilder.SavePdb ran. SavePdb → PdbWriter.WritePDBDataHelper reads the finished image back from disk (File.Copy(dllPath, ...)) to feed DIA. Since FileStream buffers writes until disposed, DIA read an incomplete on-disk image with a zeroed CodeView/RSDS GUID, producing a PDB whose identity didn't match the DLL.

Changes

ReadyToRunObjectWriter.cs: Scope the object emission in a nested using block so the stream is flushed and closed before any symbol file (PDB/PerfMap) reads the image from disk. Capture stream.Length inside the block for the map builder, which was the only remaining consumer of the open stream.

long outputFileSize;
using (FileStream stream = new FileStream(_objectFilePath, FileMode.Create))
{
    objectWriter.EmitObject(stream, _nodes, dumper: null, logger);
    outputFileSize = stream.Length;
}
// ... SavePdb / SavePerfMap now read a fully-flushed image

Notes

No regression test is added here: native PDB generation goes through DIA, which is Windows-only, and there is no cross-platform crossgen2 PDB test infrastructure to extend.

Fixes Crossgen2-generated native PDBs have zero PDB-info GUID after ObjectWriter migration #131605

Copilot

Copilot was unable to review this pull request because there is no eligible user to bill. To allow Copilot reviews on bot-authored pull requests, enable direct organization billing in your organization's Copilot settings.

azure-pipelines · 2026-07-30T18:10:15Z

Azure Pipelines: 16 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

The FileStream that ReadyToRunObjectWriter writes the R2R image into was kept open (via a method-scoped `using`) while SymbolFileBuilder.SavePdb read the image back from disk to generate the native PDB. Because the FileStream buffers writes until disposed, the PDB writer could observe an incomplete image with a zeroed CodeView/RSDS GUID, producing native PDBs whose PDB-info GUID did not match the DLL. Close the stream (capturing the file size for the map builder) before generating symbol files. Co-authored-by: elinor-fung <47805090+elinor-fung@users.noreply.github.com>

Copilot

Copilot was unable to review this pull request because there is no eligible user to bill. To allow Copilot reviews on bot-authored pull requests, enable direct organization billing in your organization's Copilot settings.

azure-pipelines · 2026-07-30T18:58:57Z

Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

elinor-fung · 2026-07-30T19:01:57Z

No regression test is added here: native PDB generation goes through DIA, which is Windows-only, and there is no cross-platform crossgen2 PDB test infrastructure to extend.

@copilot We already have PdbChecker. Can we update that to also validate the PDB and image match?

Extend PdbChecker to optionally take the crossgen2 output image via a new `--image <file>` argument. When supplied, it reads the image's CodeView/RSDS debug record and verifies the DIA-reported PDB-info GUID/age is nonzero and matches the image identity, regressing the zero-GUID native PDB bug. Wire the crossgen2 R2R test PDB check to pass the output image. Co-authored-by: elinor-fung <47805090+elinor-fung@users.noreply.github.com>

Copilot

Copilot was unable to review this pull request because there is no eligible user to bill. To allow Copilot reviews on bot-authored pull requests, enable direct organization billing in your organization's Copilot settings.

Avoid silently skipping validation and returning success when a PDB file argument is omitted but --image is supplied. Co-authored-by: elinor-fung <47805090+elinor-fung@users.noreply.github.com>

Copilot

Copilot was unable to review this pull request because there is no eligible user to bill. To allow Copilot reviews on bot-authored pull requests, enable direct organization billing in your organization's Copilot settings.

Copilot · 2026-07-30T19:10:18Z

No regression test is added here: native PDB generation goes through DIA, which is Windows-only, and there is no cross-platform crossgen2 PDB test infrastructure to extend.

@copilot We already ha...

Done. PdbChecker now takes an optional --image <file> argument: when supplied it reads the image's CodeView/RSDS debug record and verifies the DIA-reported PDB-info GUID/age is nonzero and matches the image identity, failing otherwise. The crossgen2 R2R test PDB check in CLRTest.CrossGen.targets now passes the output image, so this runs as a regression guard for the zero-GUID bug.

Note

This comment was generated by GitHub Copilot.

…taFromPdb Keep the PDB file as the first positional argument. When --image is supplied, MSDiaSymbolReader reads the image's CodeView/RSDS identity and loads the PDB via DIA's loadAndValidateDataFromPdb, which throws when the PDB-info GUID/age don't match the image (including the all-zero GUID regression), instead of comparing identities manually in Program.cs. Co-authored-by: elinor-fung <47805090+elinor-fung@users.noreply.github.com>

Copilot

Copilot was unable to review this pull request because there is no eligible user to bill. To allow Copilot reviews on bot-authored pull requests, enable direct organization billing in your organization's Copilot settings.

Co-authored-by: elinor-fung <47805090+elinor-fung@users.noreply.github.com>

Copilot

Copilot was unable to review this pull request because there is no eligible user to bill. To allow Copilot reviews on bot-authored pull requests, enable direct organization billing in your organization's Copilot settings.

Co-authored-by: elinor-fung <47805090+elinor-fung@users.noreply.github.com>

Copilot

Copilot was unable to review this pull request because there is no eligible user to bill. To allow Copilot reviews on bot-authored pull requests, enable direct organization billing in your organization's Copilot settings.

Co-authored-by: Elinor Fung <elfung@microsoft.com>

Copilot

Copilot's findings

Files reviewed: 4/4 changed files
Comments generated: 1

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Copilot's findings

Comments suppressed due to low confidence (2)

src/tests/Common/CLRTest.CrossGen.targets:406

__PdbFile and __OutputFile are appended to the PdbChecker command without quoting. If the test layout path contains spaces (common on Windows agents), the --image argument (and even the PDB path) will be split and PdbChecker will validate the wrong file or fail to start. Quote both paths when composing the command.

            set __CheckPdbCommand=!__DotNet!
            set __CheckPdbCommand=!__CheckPdbCommand! "!CORE_ROOT!\PdbChecker\PdbChecker.dll"
            set __CheckPdbCommand=!__CheckPdbCommand! !__PdbFile! --image !__OutputFile! @(CheckPdbSymbol->'%22%(Identity)%22', ' ')
            echo "!__CheckPdbCommand!"

src/coreclr/tools/PdbChecker/MSDiaSymbolReader.cs:88

The constructor now reads/validates both the PDB and (optionally) an image file, but the catch block always wraps failures as "Error opening PDB file ...". If imageFile is missing/corrupt or has no CodeView record, the error message will misleadingly blame the PDB. Include the image path in the wrapped message when imageFile is provided.

        catch (Exception ex)
        {
            throw new Exception($"Error opening PDB file {pdbFile}", ex);
        }

Files reviewed: 4/4 changed files
Comments generated: 0 new

Initial plan

44ad1a3

Copilot AI assigned Copilot and elinor-fung Jul 30, 2026

Copilot AI review requested due to automatic review settings July 30, 2026 18:09

github-project-automation Bot added this to AppModel Jul 30, 2026

Copilot AI reviewed Jul 30, 2026

Copilot started work on behalf of elinor-fung July 30, 2026 18:10 View session

Copilot AI linked an issue Jul 30, 2026 that may be closed by this pull request

Crossgen2-generated native PDBs have zero PDB-info GUID after ObjectWriter migration #131605

Open

Copilot AI review requested due to automatic review settings July 30, 2026 18:15

Copilot AI reviewed Jul 30, 2026

Copilot AI changed the title ~~[WIP] Fix zero PDB-info GUID in Crossgen2-generated native PDBs~~ Flush Crossgen2 R2R output stream before generating native PDB Jul 30, 2026

Copilot finished work on behalf of elinor-fung July 30, 2026 18:16

Copilot AI requested a review from elinor-fung July 30, 2026 18:16

github-actions Bot added the area-crossgen2-coreclr only use for closed issues label Jul 30, 2026

jkoritzinsky approved these changes Jul 30, 2026

View reviewed changes

elinor-fung marked this pull request as ready for review July 30, 2026 18:58

Copilot started work on behalf of elinor-fung July 30, 2026 19:03 View session

Copilot AI review requested due to automatic review settings July 30, 2026 19:09

Copilot AI reviewed Jul 30, 2026

PdbChecker: error when --image is given without a PDB file

631b0c0

Avoid silently skipping validation and returning success when a PDB file argument is omitted but --image is supplied. Co-authored-by: elinor-fung <47805090+elinor-fung@users.noreply.github.com>

Copilot AI review requested due to automatic review settings July 30, 2026 19:10

Copilot AI reviewed Jul 30, 2026

Copilot finished work on behalf of elinor-fung July 30, 2026 19:11

elinor-fung reviewed Jul 30, 2026

View reviewed changes

Comment thread src/coreclr/tools/PdbChecker/Program.cs Outdated

Comment thread src/coreclr/tools/PdbChecker/Program.cs Outdated

Copilot started work on behalf of elinor-fung July 30, 2026 19:59 View session

Copilot AI review requested due to automatic review settings July 30, 2026 20:05

Copilot AI reviewed Jul 30, 2026

PdbChecker: document sig=0 for RSDS (PDB 7.0) validation

d013216

Co-authored-by: elinor-fung <47805090+elinor-fung@users.noreply.github.com>

Copilot AI review requested due to automatic review settings July 30, 2026 20:06

Copilot AI reviewed Jul 30, 2026

elinor-fung reviewed Jul 30, 2026

View reviewed changes

Comment thread src/coreclr/tools/PdbChecker/MSDiaSymbolReader.cs Outdated

Copilot finished work on behalf of elinor-fung July 30, 2026 20:25

Copilot AI requested a review from elinor-fung July 30, 2026 20:25

Copilot started work on behalf of elinor-fung July 30, 2026 20:25 View session

Remove PdbGuid/PdbAge properties from MSDiaSymbolReader, use locals

809f5c6

Co-authored-by: elinor-fung <47805090+elinor-fung@users.noreply.github.com>

Copilot AI review requested due to automatic review settings July 30, 2026 20:29

Copilot AI reviewed Jul 30, 2026

Copilot finished work on behalf of elinor-fung July 30, 2026 20:30

elinor-fung reviewed Jul 30, 2026

View reviewed changes

Comment thread src/coreclr/tools/PdbChecker/MSDiaSymbolReader.cs Outdated

Comment thread src/coreclr/tools/PdbChecker/MSDiaSymbolReader.cs Outdated

Comment thread src/coreclr/tools/PdbChecker/MSDiaSymbolReader.cs Outdated

Apply batched suggestions from code review

527c235

Co-authored-by: Elinor Fung <elfung@microsoft.com>

Copilot AI review requested due to automatic review settings July 30, 2026 21:09

Copilot started reviewing on behalf of elinor-fung July 30, 2026 21:09 View session

Copilot AI reviewed Jul 30, 2026

View reviewed changes

Comment thread src/coreclr/tools/PdbChecker/MSDiaSymbolReader.cs Outdated

Potential fix for pull request finding

a9e5f68

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings July 30, 2026 21:27

Copilot started reviewing on behalf of elinor-fung July 30, 2026 21:27 View session

Copilot AI reviewed Jul 30, 2026

View reviewed changes

jtschuster added area-ReadyToRun and removed area-crossgen2-coreclr only use for closed issues labels Jul 30, 2026

Uh oh!

Conversation

Copilot AI commented Jul 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Root cause

Changes

Notes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

azure-pipelines Bot commented Jul 30, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

azure-pipelines Bot commented Jul 30, 2026

Uh oh!

elinor-fung commented Jul 30, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Jul 30, 2026

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot's findings

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot's findings

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Copilot AI commented Jul 30, 2026 •

edited

Loading