Delete PlatformDetection.IsMariner#129370
Merged
Merged
Conversation
Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
jkotas
June 13, 2026 16:36
View session
Contributor
|
Tagging subscribers to this area: @bartonjs, @vcsjones, @dotnet/area-system-security |
jkotas
reviewed
Jun 13, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the legacy PlatformDetection.IsMariner distro check from test infrastructure and updates tests that previously had Mariner-specific branching/skip logic, aligning the suite with currently supported Azure Linux naming/behavior.
Changes:
- Removed
PlatformDetection.IsMarinerfrom Unix platform detection utilities. - Removed the Mariner-specific “ChaCha/Poly disabled by distro build options” branch in
ChaCha20Poly1305support validation. - Updated an
[ActiveIssue]annotation to no longer referenceIsMariner.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/libraries/System.Security.Cryptography/tests/X509Certificates/RevocationTests/AiaTests.cs | Adjusts [ActiveIssue] conditions to remove the IsMariner reference. |
| src/libraries/System.Security.Cryptography/tests/ChaCha20Poly1305Tests.cs | Removes Mariner-only expected-support logic branch for ChaCha20-Poly1305. |
| src/libraries/Common/tests/TestUtilities/System/PlatformDetection.Unix.cs | Deletes the IsMariner distro detection property. |
vcsjones
approved these changes
Jun 13, 2026
Open
3 tasks
Member
|
/ba-g infrastructure timeout in unrelated leg |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mariner was a code name for early Azure Linux versions that are no longer supported. Removes all references to
PlatformDetection.IsMariner.