Skip to content

Optimize GetType with known type #129365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MichalPetryka wants to merge 4 commits into
base: main
Choose a base branch
from
+22 −0
Open

Optimize GetType with known type #129365

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
899b70e
Optimize GetType with known type
MichalPetryka Jun 13, 2026
8ec4be5
Apply jitformat patch
MihuBot Jun 13, 2026
5670688
Simplify shared generic check
MichalPetryka Jun 13, 2026
b3bad56
Apply jitformat patch
MihuBot Jun 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions src/coreclr/jit/importercalls.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4704,6 +4704,28 @@ GenTree* Compiler::impIntrinsic(CORINFO_CLASS_HANDLE clsHnd,
}
}

// Try to load handle directly for known types
if (retNode == nullptr)
{
GenTree* tree = impStackTop().val;
bool isExact = false;
bool notNull = false;
CORINFO_CLASS_HANDLE typeHnd = gtGetClassHandle(tree, &isExact, &notNull);
if ((typeHnd != NO_CLASS_HANDLE) && isExact)
{
assert((info.compCompHnd->getClassAttribs(typeHnd) & CORINFO_FLG_GENERIC_TYPE_VARIABLE) == 0);
if (!eeIsSharedInst(typeHnd) && notNull && !fgAddrCouldBeNull(tree))
{
JITDUMP("Optimizing object.GetType() with known type to typeof\n");
impPopStack();
GenTree* handle = gtNewIconEmbClsHndNode(typeHnd);
GenTree* helper =
gtNewHelperCallNode(CORINFO_HELP_TYPEHANDLE_TO_RUNTIMETYPE, TYP_REF, handle);
retNode = gtWrapWithSideEffects(helper, tree, GTF_ALL_EFFECT, true);
}
}
}

#ifdef DEBUG
if (retNode != nullptr)
{
Expand Down
Loading