Skip to content

Fix ConnectAsync_WithBuffer_Succeeds test to include Apple mobile platforms #125717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kotlarmilos merged 1 commit into from
Mar 18, 2026
Merged

Fix ConnectAsync_WithBuffer_Succeeds test to include Apple mobile platforms #125717

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/libraries/System.Net.Sockets/tests/FunctionalTests/Connect.Unix.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,11 +220,11 @@ public async Task ConnectAsync_WithBuffer_Succeeds()
Assert.Equal(SocketError.Success, saea.SocketError);
Assert.True(client.Blocking);

// On macOS, TFO (connectx) may complete the connect+send in a single
// On Apple platforms, TFO (connectx) may complete the connect+send in a single
// syscall, so the socket can end up blocking even on the async path.
// On Linux, async connect always leaves the socket non-blocking when
// buffer > 0 because SendToAsync is pending.
if (!completedAsync || OperatingSystem.IsMacOS())
if (!completedAsync || PlatformDetection.IsApplePlatform)
{
Assert.False(IsSocketNonBlocking(client));
}
Expand Down
Loading