Add minimum remaining-data checks for fixed-size binary reads#125700
Closed
FUTURE-SL wants to merge 1 commit intodotnet:mainfrom
Closed
Add minimum remaining-data checks for fixed-size binary reads#125700FUTURE-SL wants to merge 1 commit intodotnet:mainfrom
FUTURE-SL wants to merge 1 commit intodotnet:mainfrom
Conversation
Added EnsureCanRead method to validate byte count before reading.
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-io |
Member
|
This is unexpected behaviour change and degrades performance. It's the stream's responsibility to reject oversized reads. |
adamsitnik
requested changes
Mar 18, 2026
Member
adamsitnik
left a comment
There was a problem hiding this comment.
Stream.Length will often perform a sys-call. This is a performance regression.
Stream.Length can throw an exception for seekable Streams. This is a breaking change.
The PR has no tests that show the benefits. Please open an issue first and describe the problem you are facing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds pre-read validation for operations where the required byte count is known in advance.
What changed:
EnsureCanRead(int byteCount)InternalRead(Span<byte>)ReadExactly(Span<byte>)ReadString()after reading the encoded byte lengthWhy: