Skip to content

Filter out SPMI metric diffs smaller than ±0.001% #125684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 6 commits into
base: main
Choose a base branch
from
+1 −1
Open

Filter out SPMI metric diffs smaller than ±0.001% #125684

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b6a6af0
Initial plan
Copilot Mar 17, 2026
2f34ffe
Filter out SPMI metric diffs smaller than +/- 0.01%
Copilot Mar 17, 2026
354ed5b
Simplify: inline abs(compute_pct(...)) >= 0.01 check directly
Copilot Mar 17, 2026
97e1984
Dummy JIT change to trigger SPMI pipeline
Copilot Mar 17, 2026
fccf298
Update superpmi.py
EgorBo Mar 18, 2026
8812704
Update compiler.cpp
EgorBo Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/coreclr/scripts/superpmi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3564,7 +3564,7 @@ def fmt_val(v):
metrics_with_diffs = set()
for metric in all_metrics:
significant_diffs = [(mch, base, diff) for (mch, _, base, diff) in metric_diffs
if metric in base and base[metric] != diff[metric]]
if metric in base and abs(compute_pct(base[metric], diff[metric])) >= 0.001]
if not significant_diffs:
continue

Expand Down
Loading