Skip to content

Skip entry-point trim roots for library outputs #125673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
+51 −2
Draft

Skip entry-point trim roots for library outputs #125673

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc1e81c
Initial plan
Copilot Mar 17, 2026
72d1e34
Avoid entry-point roots for trimmed library projects
Copilot Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/tools/illink/src/ILLink.Tasks/build/Microsoft.NET.ILLink.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,9 +219,9 @@ Copyright (c) .NET Foundation. All rights reserved.
<TrimmerSingleWarn Condition=" '$(TrimmerSingleWarn)' == '' ">true</TrimmerSingleWarn>
</PropertyGroup>

<!-- Root the main assembly entry point. -->
<!-- Root the main assembly entry point for non-library projects. -->
<ItemGroup>
<TrimmerRootAssembly Include="@(IntermediateAssembly->'%(Filename)')" RootMode="EntryPoint" />
<TrimmerRootAssembly Include="@(IntermediateAssembly->'%(Filename)')" RootMode="EntryPoint" Condition="'$(OutputType)' != 'Library'" />
</ItemGroup>

<ItemGroup>
Expand Down
49 changes: 49 additions & 0 deletions src/tools/illink/test/ILLink.Tasks.Tests/MicrosoftNETILLinkTargetsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
// Copyright (c) .NET Foundation and contributors. All rights reserved.
// Licensed under the MIT license. See LICENSE file in the project root for full license information.

using System;
using System.IO;
using System.Linq;
using System.Xml.Linq;
using Xunit;

#nullable enable

namespace ILLink.Tasks.Tests
{
public class MicrosoftNETILLinkTargetsTests
{
[Fact]
public void EntryPointRootIsNotAddedForLibraryProjects()
{
XDocument targets = XDocument.Load(GetTargetsFilePath());

XElement entryPointRoot = targets.Descendants()
.Where(element => element.Name.LocalName == "TrimmerRootAssembly")
.Single(element =>
GetAttributeValue(element, "Include") == "@(IntermediateAssembly->'%(Filename)')" &&
GetAttributeValue(element, "RootMode") == "EntryPoint");

Assert.Equal("'$(OutputType)' != 'Library'", GetAttributeValue(entryPointRoot, "Condition"));
}

private static string GetTargetsFilePath()
{
DirectoryInfo? directory = new DirectoryInfo(AppContext.BaseDirectory);

while (directory is not null)
{
string targetsFilePath = Path.Combine(directory.FullName, "src", "tools", "illink", "src", "ILLink.Tasks", "build", "Microsoft.NET.ILLink.targets");
if (File.Exists(targetsFilePath))
return targetsFilePath;

directory = directory.Parent;
}

throw new FileNotFoundException("Could not locate Microsoft.NET.ILLink.targets.");
}

private static string GetAttributeValue(XElement element, string attributeName)
=> element.Attribute(attributeName)?.Value ?? throw new InvalidDataException($"Missing '{attributeName}' attribute.");
}
}
Loading