Skip to content

[RyuJIT] Always insert r2r indirection cell at the end of the args list #125670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kg wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[RyuJIT] Always insert r2r indirection cell at the end of the args list #125670

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions src/coreclr/jit/morph.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1780,12 +1780,10 @@ void CallArgs::AddFinalArgsAndDetermineABIInfo(Compiler* comp, GenTreeCall* call
// Push the stub address onto the list of arguments.
NewCallArg indirCellAddrArg =
NewCallArg::Primitive(indirectCellAddress).WellKnown(WellKnownArg::R2RIndirectionCell);
#ifdef TARGET_WASM
// On wasm we need to ensure we put the indirection cell address last in LIR, after the SP and formal args.
// On wasm we need to ensure we put the indirection cell address last in LIR, after the SP and formal args,
// because it is used as the portable entry point (PEP) which is the last argument slot. On other targets
// it shouldn't matter whether we evaluate the argument early or late since it goes into a dedicated register.
PushBack(comp, indirCellAddrArg);
#else
InsertAfterThisOrFirst(comp, indirCellAddrArg);
#endif // TARGET_WASM
}
#endif // defined(FEATURE_READYTORUN)

Expand Down
Loading