Use SDK NativeCompile hook for ILC publish integration by sbomer · Pull Request #125629 · dotnet/runtime

sbomer · 2026-03-16T18:59:06Z

...instead of BeforeTargets/AfterTargets.

Redefine the SDK's empty NativeCompile placeholder target with the actual NativeAOT compilation pipeline, replacing the fragile BeforeTargets/AfterTargets hooks that previously sequenced ILC into the publish flow.

Rename ComputeLinkedFilesToPublish to NativeCompile in Publish.targets, removing AfterTargets="ComputeResolvedFilesToPublishList"
Remove BeforeTargets="Publish" from SetupProperties, ComputeIlcCompileInputs, and ImportRuntimeIlcPackageTarget (all reachable via DependsOnTargets chains)
Keep empty ComputeLinkedFilesToPublish and CopyNativeBinary for back-compat

…ILC publish integration Redefine the SDK's empty NativeCompile placeholder target with the actual NativeAOT compilation pipeline, replacing the fragile BeforeTargets/AfterTargets hooks that previously sequenced ILC into the publish flow. - Rename ComputeLinkedFilesToPublish to NativeCompile in Publish.targets, removing AfterTargets="ComputeResolvedFilesToPublishList" - Remove BeforeTargets="Publish" from SetupProperties, ComputeIlcCompileInputs, and ImportRuntimeIlcPackageTarget (all reachable via DependsOnTargets chains) - Keep empty ComputeLinkedFilesToPublish and CopyNativeBinary for back-compat

dotnet-policy-service · 2026-03-16T19:00:19Z

Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR updates NativeAOT publish integration to use the .NET SDK’s NativeCompile hook as the primary publish pipeline entry point, replacing prior sequencing via BeforeTargets/AfterTargets to make ordering more explicit and less fragile.

Changes:

Redefines the SDK NativeCompile placeholder target to run the NativeAOT pipeline and update ResolvedFileToPublish.
Renames the prior publish hook target (ComputeLinkedFilesToPublish) out of the execution path and keeps it as an empty back-compat target.
Removes BeforeTargets="Publish" from several targets, relying on DependsOnTargets chains instead.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets	Removes `BeforeTargets="Publish"` from `SetupProperties` and `ComputeIlcCompileInputs`, relying on dependency chains to run them when needed.
src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Publish.targets	Implements NativeAOT publish integration by redefining `NativeCompile`; adds empty `ComputeLinkedFilesToPublish` for compatibility.
src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets	Removes `BeforeTargets="Publish"` from `ImportRuntimeIlcPackageTarget`, relying on dependency chains.

src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Publish.targets

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Refactors NativeAOT publish integration to use the .NET SDK’s NativeCompile hook (instead of BeforeTargets/AfterTargets-based sequencing) so the ILC + native link pipeline runs at an explicit, stable point in the publish target graph.

Changes:

Replaces the previous ComputeLinkedFilesToPublish publish hook with an implementation of NativeCompile that runs NativeAOT compilation and updates ResolvedFileToPublish.
Removes BeforeTargets="Publish" from several preparatory targets so they execute via dependency chains rather than fragile publish hooks.
Keeps ComputeLinkedFilesToPublish (and existing CopyNativeBinary) as empty/back-compat targets.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets	Stops forcing `SetupProperties`/`ComputeIlcCompileInputs` to run via `BeforeTargets="Publish"`; relies on existing dependency flow.
src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Publish.targets	Implements `NativeCompile` as the NativeAOT publish integration point; leaves `ComputeLinkedFilesToPublish` as an empty compatibility target.
src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets	Removes `BeforeTargets="Publish"` from runtime ILC pack import target to rely on dependency chains.

The test infrastructure directly imported SingleEntry.targets from Directory.Build.targets, which is evaluated before Microsoft.NET.Sdk.targets. This caused the SDK's empty NativeCompile placeholder (in Publish.targets) to overwrite the NativeAOT redefinition (MSBuild last-definition-wins), resulting in no native compilation during NativeAOT test runs. Use AfterMicrosoftNETSdkTargets to defer the import to after all SDK targets, matching the pattern already used for ReadyToRun targets in tests.singlefile.targets.

agocke

Everything looks good except the stuff about AfterMicrosoftNETSdkTargets -- I'm not sure I understand well enough what's going on there to say whether or not it's correct.

sbomer · 2026-03-16T22:44:41Z

The import order is:

This repo's test build targets (which used to directly import the SingleEntry.targets, eventually defining the NativeCompile target)
SDK targets that define empty NativeCompile target
NuGet package targets

We needed a way to ensure the repo testing imports SingleEntry.targets after the empty NativeCompile target is defined, like what happens in the nuget flow. Hopefully using AfterMicrosoftNETSdkTargets to delay the import doesn't cause other ordering issues...

… load Deferring the ILC import via AfterMicrosoftNETSdkTargets also deferred the PublishTrimmed=true that Microsoft.NETCore.Native.targets sets at evaluation time. This caused liveILLink.targets to compute _RequiresLiveILLink=false (since PublishTrimmed was not yet set), so ILLink targets were never loaded, and _PrepareTrimConfiguration was missing at build time. Set PublishTrimmed=true explicitly in the NativeAOT test PropertyGroups before liveILLink.targets is imported. NativeAOT always enables trimming, so this is semantically correct.

Copilot

Pull request overview

Switches NativeAOT publish integration to use the SDK’s NativeCompile placeholder hook instead of BeforeTargets/AfterTargets, improving sequencing reliability in the publish pipeline.

Changes:

Redefines NativeCompile to run the NativeAOT compilation/linking pipeline and updates publish items accordingly.
Removes BeforeTargets="Publish" hooks from several NativeAOT targets, relying on dependency chains instead.
Defers importing ILC targets via AfterMicrosoftNETSdkTargets and sets PublishTrimmed earlier to ensure trim configuration targets are available.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
src/tests/Directory.Build.targets	Defers ILC target import via `AfterMicrosoftNETSdkTargets` and sets `PublishTrimmed` early for NativeAOT test builds.
src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets	Removes `BeforeTargets="Publish"` from NativeAOT setup/inputs targets.
src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Publish.targets	Moves publish integration work into `NativeCompile`, leaving an empty `ComputeLinkedFilesToPublish` for back-compat.
src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets	Removes `BeforeTargets="Publish"` from runtime pack import target.
eng/testing/tests.singlefile.targets	Defers ILC import via `AfterMicrosoftNETSdkTargets` and sets `PublishTrimmed` early for single-file NativeAOT tests.

src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets

src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets

src/tests/Directory.Build.targets

eng/testing/tests.singlefile.targets

steveisok · 2026-03-17T11:29:04Z

@sbomer I believe this should fix the forward flow build failure in dotnet/dotnet#5506, correct?

sbomer · 2026-03-17T17:11:13Z

No, that's not the intention (though it might help) - I think that needs a separate fix.

…ILC import Replace the AfterMicrosoftNETSdkTargets hook with the SDK's ILCompilerTargetsPath extension point to import ILC targets in the correct order (before ILLink), fixing the DynamicCodeSupport property evaluation error. Gate IlcSetupPropertiesDependsOn on _IlcReferencedAsPackage to skip NuGet package resolution when using live ILC targets.

Copilot

Pull request overview

Updates NativeAOT publish integration to use the .NET SDK’s NativeCompile hook (instead of BeforeTargets/AfterTargets), aligning the in-repo ILC pipeline with the SDK’s publish sequencing and making the integration less order-fragile.

Changes:

Redefines the SDK placeholder NativeCompile target to run the NativeAOT publish pipeline and keeps ComputeLinkedFilesToPublish as an empty back-compat target.
Removes BeforeTargets="Publish" hooks from key ILC setup/inputs targets so ordering is driven by dependency chains + SDK sequencing.
Updates test build infrastructure to use the SDK’s ILCompilerTargetsPath import hook (and removes direct imports of Microsoft.DotNet.ILCompiler.SingleEntry.targets).

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/tests/Directory.Build.targets	Switches nativeaot test builds to use `ILCompilerTargetsPath` / `PublishAot` hook instead of directly importing ILC targets.
src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets	Removes `BeforeTargets="Publish"` from `SetupProperties` / `ComputeIlcCompileInputs` to rely on dependency sequencing.
src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Publish.targets	Moves publish-time work from `ComputeLinkedFilesToPublish` to `NativeCompile` and keeps an empty `ComputeLinkedFilesToPublish` for back-compat.
src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets	Makes `IlcSetupPropertiesDependsOn` conditional on package-based toolchain usage and removes `BeforeTargets="Publish"` from runtime pack import.
eng/testing/tests.singlefile.targets	Switches single-file test publish (NativeAOT) to use `ILCompilerTargetsPath` hook instead of directly importing ILC targets.

PublishAot=true (added for SDK import order) enables EnableSingleFileAnalyzer, which promotes IL3000 (Assembly.Location usage) to an error in tracing tests. Disable it alongside the existing EnableTrimAnalyzer and EnableAotAnalyzer suppressions.

Copilot AI review requested due to automatic review settings March 16, 2026 18:59

github-actions bot added the area-NativeAOT-coreclr label Mar 16, 2026

dotnet-policy-service bot assigned sbomer Mar 16, 2026

github-project-automation bot added this to AppModel Mar 16, 2026

Copilot started reviewing on behalf of sbomer March 16, 2026 19:00 View session

Copilot AI reviewed Mar 16, 2026

View reviewed changes

src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Publish.targets Outdated Show resolved Hide resolved

SingleAccretion mentioned this pull request Mar 16, 2026

[NativeAOT-LLVM] Post-merge tasks dotnet/runtimelab#2472

Open

Potential fix for pull request finding

bd12de9

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings March 16, 2026 19:06

Copilot started reviewing on behalf of sbomer March 16, 2026 19:08 View session

Copilot AI reviewed Mar 16, 2026

View reviewed changes

agocke approved these changes Mar 16, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings March 16, 2026 23:32

Copilot started reviewing on behalf of sbomer March 16, 2026 23:33 View session

Copilot AI reviewed Mar 16, 2026

View reviewed changes

steveisok mentioned this pull request Mar 17, 2026

[main] Source code updates from dotnet/runtime dotnet/dotnet#5506

Merged

build-analysis bot mentioned this pull request Mar 17, 2026

BinderTracingTest.ResolutionFlow times out #104670

Open

Copilot AI review requested due to automatic review settings March 18, 2026 18:35

sbomer force-pushed the sdk-nativecompile-hook branch from 756e72e to 4a3adf6 Compare March 18, 2026 18:35

Copilot started reviewing on behalf of sbomer March 18, 2026 18:36 View session

Copilot AI reviewed Mar 18, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use SDK NativeCompile hook for ILC publish integration#125629

Use SDK NativeCompile hook for ILC publish integration#125629
sbomer wants to merge 6 commits intodotnet:mainfrom
sbomer:sdk-nativecompile-hook

sbomer commented Mar 16, 2026

Uh oh!

dotnet-policy-service bot commented Mar 16, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

agocke left a comment

Uh oh!

sbomer commented Mar 16, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

steveisok commented Mar 17, 2026

Uh oh!

sbomer commented Mar 17, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

sbomer commented Mar 16, 2026

Uh oh!

dotnet-policy-service bot commented Mar 16, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

agocke left a comment

Choose a reason for hiding this comment

Uh oh!

sbomer commented Mar 16, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

steveisok commented Mar 17, 2026

Uh oh!

sbomer commented Mar 17, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants