Skip to content

Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2914130#124957

Merged
akoeplinger merged 1 commit intomainfrom
locfiles/95ccd669-e01f-46d0-9db3-75558288bf16
Feb 27, 2026
Merged

Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2914130#124957
akoeplinger merged 1 commit intomainfrom
locfiles/95ccd669-e01f-46d0-9db3-75558288bf16

Conversation

@dotnet-bot
Copy link
Collaborator

This is the pull request automatically created by the OneLocBuild task in the build process to check-in localized files generated based upon translation source files (.lcl files) handed-back from the downstream localization pipeline. If there are issues in translations, visit https://aka.ms/icxLocBug and log bugs for fixes. The OneLocBuild wiki is https://aka.ms/onelocbuild and the localization process in general is documented at https://aka.ms/AllAboutLoc.

@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-extensions-logging
See info in area-owners.md if you want to be subscribed.

@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2914055 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2914077 Feb 27, 2026
@akoeplinger
Copy link
Member

@svick @tarekgh the failure here is interesting, I don't think it can be caused by the loc updates:

  Starting:    Microsoft.Extensions.Logging.Generators.Roslyn4.8.Tests (parallel test collections = on [2 threads], stop on fail = off)
    Microsoft.Extensions.Logging.Generators.Tests.LoggerMessageGeneratorEmitterTests.TestBaseline_TestWithRefReadOnlyParam_Success [FAIL]
      Line 9 does not match.
      Expected Line:
              private static readonly global::System.Action<global::Microsoft.Extensions.Logging.ILogger, global::System.Int32, global::System.Exception?> __MCallback =
      Actual Line:
              private static readonly global::System.Action<global::Microsoft.Extensions.Logging.ILogger, int, global::System.Exception?> __MCallback =
      Stack Trace:
        /_/src/libraries/Microsoft.Extensions.Logging.Abstractions/tests/Microsoft.Extensions.Logging.Generators.Tests/LoggerMessageGeneratorEmitterTests.cs(389,0): at Microsoft.Extensions.Logging.Generators.Tests.LoggerMessageGeneratorEmitterTests.VerifyAgainstBaselineUsingFile(String filename, String testSourceCode)
        /_/src/libraries/Microsoft.Extensions.Logging.Abstractions/tests/Microsoft.Extensions.Logging.Generators.Tests/LoggerMessageGeneratorEmitterTests.cs(281,0): at Microsoft.Extensions.Logging.Generators.Tests.LoggerMessageGeneratorEmitterTests.TestBaseline_TestWithRefReadOnlyParam_Success()
        --- End of stack trace from previous location ---

@akoeplinger
Copy link
Member

ah it's probably missing a change similar to bd4479d3d76bfbae798f3c884fb801c35cd4d9ba from #124638, but I don't understand how that PR passed?

@svick
Copy link
Member

svick commented Feb 27, 2026

@akoeplinger I'll take a look.

@akoeplinger
Copy link
Member

akoeplinger commented Feb 27, 2026

@svick figured it out, it was because #124589 was merged (which added the new test) but #124638 didn't get a new build with that change.

@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2914077 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2914097 Feb 27, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2914097 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2914130 Feb 27, 2026
@akoeplinger
Copy link
Member

/ba-g unrelated test failure which will be fixed by #124962

@akoeplinger akoeplinger merged commit f297dfb into main Feb 27, 2026
81 of 95 checks passed
@akoeplinger akoeplinger deleted the locfiles/95ccd669-e01f-46d0-9db3-75558288bf16 branch February 27, 2026 14:32
akoeplinger added a commit that referenced this pull request Feb 27, 2026
…translation quality (#124960)

Some of the Czech language translations in
#124957 are quite bad.

This PR updates the messages to enclose C# keywords (and similar) in
single quotes, hoping this will improve translation quality.

Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants