Conversation
dd6ee14 to
33eabba
Compare
|
@ilonatommy @timcassell Is there some manual part in publishing benchmarkdotnet nightlies, or have I missed something? In the failing CI runs, it can't find the nightly that I've referenced, but it works for the scenario pipelines... |
Yes, it's tricky. In my case I was getting the version from @LoopedBard3 and that one always worked properly. |
|
Yes, we have a mirror for nightlies that we have to manually update (but we are looking into options for automatic mirroring). I will get this version mirrored and retested today 👍. |
|
Thank you |
|
/azp run |
|
The feed should be available, rerunning the checks. |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Pull request overview
This PR removes the --expose_wasm and --module V8 wasm arguments from benchmark scripts. --expose_wasm was removed from V8 in 2024, and --module is now automatically added by BenchmarkDotNet when running on V8 (via BDN PR #3020). The PR also bumps the BDN nightly version to include that fix.
Changes:
- Remove
--wasmArgs(containing--expose_wasmand--module) from WASM benchmark run configurations in CI and local scripts - Update BenchmarkDotNet to nightly
0.16.0-nightly.20260302.459which automatically adds--modulefor V8 - Update documentation examples to remove the now-unnecessary
--wasmArgsand--wasmDataDirarguments
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
scripts/run_performance_job.py |
Removes wasm_args construction and --wasmArgs BDN argument for both wasm and wasm_coreclr runtime types |
scripts/benchmarks_local.py |
Removes --wasmArgs from WasmInterpreter and WasmAOT run types, but leaves behind stale comments referencing --wasmArgs |
eng/Versions.props |
Bumps BDN version to nightly 20260302.459, which includes the fix to auto-add --module for V8 |
docs/benchmarking-workflow-dotnet-runtime.md |
Removes --wasmArgs=\"--module\" and --wasmDataDir from interpreter and AOT benchmark doc examples |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- `--expose_wasm` is obsolete - `--module` is now set by benchmarkdotnet
b6f7908 to
79083eb
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This PR removes both wasmArgs.
--moduleis now added by BenchmarkDotNet when running on V8 (dotnet/BenchmarkDotNet#3020).--expose_wasmis obsolete and was removed from V8 in 2024.