[tests] Cover NSCoding generic registrar signatures. Fixes #21256 - #26499
Open
rolfbjarne wants to merge 1 commit into
Open
[tests] Cover NSCoding generic registrar signatures. Fixes #21256#26499rolfbjarne wants to merge 1 commit into
rolfbjarne wants to merge 1 commit into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the bindings-test fixture bindings to add registrar coverage for NSDictionary<NSString, NSCoding> in both method and property signatures, targeting the device-build registrar/header generation failure described in #21256.
Changes:
- Add
NSDictionary<NSString, NSCoding>getter/setter method signatures to the registrar test interface. - Add a
NSDictionary<NSString, NSCoding>property to broaden coverage of generic NSCoding dictionary signatures.
Suppressed comments (1)
tests/bindings-test/ApiDefinition.cs:261
⚠️ The new NSCoding dictionary property is currently non-nullable; the real-world signature in #21256 is nullable, and other test properties here are marked [NullAllowed] when they can be nil. Marking this one [NullAllowed] would better cover the problematic registrar output.
[Export ("nscodingSessionDictionary")]
NSDictionary<NSString, NSCoding> NSCodingSessionDictionary { get; set; }
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+254
to
+258
| [Export ("nscodingSessionOptions")] | ||
| NSDictionary<NSString, NSCoding> GetNSCodingSessionOptions (); | ||
|
|
||
| [Export ("setNscodingSessionOptions:")] | ||
| void SetNSCodingSessionOptions (NSDictionary<NSString, NSCoding> value); |
Collaborator
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
Collaborator
🔥 [CI Build #20c7545] Test results 🔥Test results❌ Tests failed on VSTS: test results 1 tests crashed, 62 tests failed, 138 tests passed. Failures❌ dotnettests tests (iOS)1 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ dotnettests tests (MacCatalyst)1 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ dotnettests tests (macOS)1 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ dotnettests tests (tvOS)1 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ linker tests (MacCatalyst)3 tests failed, 12 tests passed.Failed tests
Html Report (VSDrops) Download ❌ linker tests (macOS)7 tests failed, 14 tests passed.Failed tests
Html Report (VSDrops) Download ❌ monotouch tests (iOS)8 tests failed, 11 tests passed.Failed tests
Html Report (VSDrops) Download ❌ monotouch tests (MacCatalyst)14 tests failed, 4 tests passed.Failed tests
Html Report (VSDrops) Download ❌ monotouch tests (macOS)18 tests failed, 3 tests passed.Failed tests
Html Report (VSDrops) Download ❌ monotouch tests (tvOS)8 tests failed, 11 tests passed.Failed tests
Html Report (VSDrops) Download ❌ Tests on macOS Tahoe (26) tests🔥 Failed catastrophically on VSTS: test results - mac_tahoe (no summary found). Html Report (VSDrops) Download Successes✅ assembly-processing: All 1 tests passed. Html Report (VSDrops) Download macOS tests✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download Linux Build VerificationPipeline on Agent |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[tests] Cover NSCoding generic registrar signatures. Fixes #21256
Fixes the issue where NSCoding generic bindings cause linker-cache compile errors in device builds.
Adds registrar binding coverage for NSDictionary<NSString, NSCoding> method and property signatures.
Fixes #21256.
🤖 Pull request created by Copilot