Skip to content

Support positional literal assembly attributes in F# builds - #20551

Open
Evangelink wants to merge 1 commit into
dotnet:mainfrom
Evangelink:dev/amauryleve/writecodefragment-literals
Open

Evangelink wants to merge 1 commit into
dotnet:mainfrom
Evangelink:dev/amauryleve/writecodefragment-literals

Conversation

@Evangelink

@Evangelink Evangelink commented Sep 14, 2026

Copy link
Copy Markdown
Member

Description

Fixes #20550

WriteCodeFragment now applies _ParameterN_IsLiteral metadata to positional arguments instead of parsing the suffix as part of the parameter index.

Checklist

  • Test cases added

  • Performance benchmarks added in case of performance changes

  • Release notes entry updated:

    Please make sure to add an entry with short succinct description of the change as well as link to this pull request to the respective release notes file, if applicable.

    Release notes files:

    • If anything under src/Compiler has been changed, please make sure to make an entry in docs/release-notes/.FSharp.Compiler.Service/<version>.md, where <version> is usually "highest" one, e.g. 42.8.200
    • If language feature was added (i.e. LanguageFeatures.fsi was changed), please add it to docs/release-notes/.Language/preview.md
    • If a change to FSharp.Core was made, please make sure to edit docs/release-notes/.FSharp.Core/<version>.md where version is "highest" one, e.g. 8.0.200.

    Information about the release notes entries format can be found in the documentation.
    Example:

    If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

✅ No release notes required

@github-actions github-actions Bot added ⚠️ Affects-Compiler-Output Tooling check: PR touches IL emission or codegen ⚠️ Affects-Build-Infra Tooling check: PR touches build infrastructure labels Sep 14, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Tooling Safety Check — Affects-Build-Infra, Affects-Compiler-Output
Affects-Build-Infra: Modifies an MSBuild task executed during builds.
Affects-Compiler-Output: Changes SDK task-generated assembly attributes.

Generated by PR Tooling Safety Check · gpt56 1.5M ·

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

⚠️ Affects-Build-Infra Tooling check: PR touches build infrastructure ⚠️ Affects-Compiler-Output Tooling check: PR touches IL emission or codegen

Projects

Status: New

Development

Successfully merging this pull request may close these issues.

F# WriteCodeFragment rejects positional literal metadata

1 participant