Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
❗ Release notes requiredYou can open this PR in browser to add release notes: open in github.dev
|
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
github-actions
Bot
added
⚠️ Affects-Design-Time
This comment has been minimized.
This comment has been minimized.
Remove the compiler XML parser, task changes, diagnostic and added fixture. Reuse GenerateILLinkSubstitutions at PrepareForILLink and pass its output as trimmer substitutions. Preserve standalone compilation and user resources without changing compiler code. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
T-Gro
changed the title
Contributor
|
🔍 Tooling Safety Check — Affects-Build-Infra, Affects-Compiler-Output, Affects-Test-Tooling
|
Keep descriptor generation and trimmer arguments together, remove unnecessary XML quote escaping, and explain the separate input needed when the opt-out changes. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Member
Author
|
/azp run fsharp-ci |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Embed defaults before compiler resource inputs are collected and let custom descriptors take precedence. Combine only unconditional metadata-removal documents during static linking, including already-combined producer assemblies, and preserve bounded mapped resource payloads. Consolidate affected test duplication while retaining quotation and reflection coverage; add direct and chained descriptor composition checks. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
T-Gro
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generated file was added after compiler resource inputs had already been collected. Add it before that collection; existing custom XML takes precedence. Combine only unconditional F# metadata-removal rules when assemblies are linked, preserving other XML unchanged.