Merge duplicate .cctors for generic unions with nullary cases and static bindings (#19445) - #20428
Open
edgarfgp wants to merge 4 commits into
Open
Merge duplicate .cctors for generic unions with nullary cases and static bindings (#19445)#20428edgarfgp wants to merge 4 commits into
edgarfgp wants to merge 4 commits into
Conversation
Contributor
❗ Release notes requiredYou can open this PR in browser to add release notes: open in github.dev
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A generic union with a nullary case crashes the compiler when it also has
static member valorstatic letbindings.Fixes #19445.
Before
After
Cause
Two code paths each contribute a
.cctorto the union type: union erasure emits one initializing the nullary-case singleton field (_unique_A), and the static bindings of a generic type are compiled into a.cctormember for a non-generic type they run from the file initializer instead, which is whytype U = Awithstatic member valalready worked.TypeDefBuilder.AddMethodDefappended the second one and ilwrite rejected the duplicate.The two are now merged into the single
.cctorIL permits: the straight-line singleton initializer (no locals, no handlers, no control flow) is prepended into the other initializer, so the singleton is initialized before user static bindings run the same order the non-generic path produces, and required because a binding may read the singleton:The merged initializer passes ILVerify, and no previously-compiling code changes shape the merge only happens where compilation used to fail.