[MicroPerf] Inline the free-variable typar foldBacks - #20385
Open
T-Gro wants to merge 1 commit into
Open
Conversation
T-Gro
added
the
NO_RELEASE_NOTES
T-Gro
marked this pull request as ready for review
August 27, 2026 13:07
Contributor
|
T-Gro
force-pushed
the
t-gro-freevars-inline-foldback
branch
from
August 27, 2026 13:33
276248a to
198fdf4
Compare
github-actions
Bot
added
the
AI-Tooling-Check-Bypassed
abonie
reviewed
Sep 1, 2026
| // Bound type vars form a recursively-referential set due to constraints, e.g. A: I<B>, B: I<A> | ||
| // So collect up free vars in all constraints first, then bind all variables | ||
| let acc = | ||
| List.foldBack (fun (tp: Typar) acc -> accFreeInTyparConstraints opts tp.Constraints acc) tps acc |
Member
There was a problem hiding this comment.
FYI, LLM flagged this as another good opportunity to apply the new version of foldBack
abonie
approved these changes
Sep 1, 2026
github-project-automation
Bot
moved this from New
to In Progress
in F# Compiler and Tooling
accFreeInTyparConstraints and accFreeInTypars fold accFreeInTyparConstraint / accFreeTyparRef over a typar's constraint and typar lists during free-variable computation, one of the hottest traversals in the compiler. Passing those top-level functions to List.foldBack allocated a partial- application closure per call, over typically tiny (often empty) lists where the closure is the entire cost. Switch both folds to ListInline.foldBack (added in the parent change), whose InlineIfLambda folder inlines the top-level partial application, so no closure is allocated. Fold order is unchanged; compiler output is byte-identical under --deterministic+. Measured (dotnet-trace gc-verbose, 6 self-compiles of a 120-file corpus): accFreeInTyparConstraints closure 147.8 MB -> 0, accFreeTyparRef closure 238.8 MB -> 0. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c6610fae-a96e-4421-a920-e73de4fc94dc
abonie
force-pushed
the
t-gro-freevars-inline-foldback
branch
from
September 4, 2026 13:13
198fdf4 to
e4f972f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #20384 — depends on its
ListInlinemodule; the base auto-retargets tomainwhen #20384 merges.Free-variable computation is one of the hottest compiler traversals.
accFreeInTyparConstraintsandaccFreeInTyparsfold the top-levelaccFreeInTyparConstraint/accFreeTyparRefover a typar's constraint and typar lists — usually tiny or empty. Passed toList.foldBack, each call allocated a partial-application closure; sincefoldBackbuilds no result list, that closure is the entire allocation.ListInline.foldBackinlines the folder (InlineIfLambda) and the top-level partial application fuses, so nothing is allocated.Closures eliminated (dotnet-trace
gc-verbose, 6 self-compiles of a 120-file corpus):accFreeInTyparConstraint opts(foldBack)accFreeTyparRef opts(foldBack)Fold order is unchanged, so free-variable results are identical; compiler output is byte-identical under
--deterministic+(SHA-256 match vs base), and tests pass.