Enforce compiler-semantic attributes in signature conformance (issue #19560)#19880
Open
T-Gro wants to merge 7 commits into
Open
Enforce compiler-semantic attributes in signature conformance (issue #19560)#19880T-Gro wants to merge 7 commits into
T-Gro wants to merge 7 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…(issue #19560) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
❗ Release notes required
|
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #19560.
When an implementation file declares a compiler-semantic attribute (such as []) on a value or member, tooling does not consult the implementation when a corresponding .fsi signature file is present. This means attributes only on the impl are silently lost, changing the contract observed by consumers (inlining behaviour, dynamic dispatch, codegen).
This PR adds a signature conformance check that enforces these attributes must also appear in the signature, producing a clear error when they are missing.
Changes
Testing