Skip to content

Bugfix :: Coloring for case testers and with#19311

Draft
T-Gro wants to merge 3 commits intomainfrom
bugfix-coloring-recordWith-iscasetester
Draft

Bugfix :: Coloring for case testers and with#19311
T-Gro wants to merge 3 commits intomainfrom
bugfix-coloring-recordWith-iscasetester

Conversation

@T-Gro
Copy link
Member

@T-Gro T-Gro commented Feb 17, 2026

Coloring issues identified at #19252 (comment) and
#19252 (comment)

@github-actions
Copy link
Contributor

github-actions bot commented Feb 17, 2026

❗ Release notes required


✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/10.0.300.md

@T-Gro T-Gro force-pushed the bugfix-coloring-recordWith-iscasetester branch from fff6aa7 to 6103fca Compare February 17, 2026 12:47
@T-Gro
Copy link
Member Author

T-Gro commented Feb 17, 2026

@kerams :

Another thing which fell out of the implementation is that we can decide to color the union case accessor the same we color its constructor and the case itself, i.e. not like a property.

I can see reasoning for both "its all artifacts of the case - declaration, constructor, tester" as well as "its just another member".

See here how it si colored differently from the custom prop., I kind of like it. WDYT about it?
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: New

Development

Successfully merging this pull request may close these issues.

1 participant