Add regression tests for 3 previously-fixed codegen issues#19309
Open
Add regression tests for 3 previously-fixed codegen issues#19309
Conversation
Contributor
✅ No release notes required |
T-Gro
force-pushed
the
codegen/small-fixes-and-tests
branch
from
c777f60 to
581af3b
Compare
T-Gro
changed the title
Add 9 regression tests covering 3 codegen issues that are already fixed on main but lacked test coverage. - #13100: --platform:x64 no longer sets Bit32Machine PE flag - #11935: unmanaged constraint emits modreq + IsUnmanagedAttribute for C# interop - #7861: Assembly references emitted for types used only in attributes Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
T-Gro
force-pushed
the
codegen/small-fixes-and-tests
branch
from
581af3b to
6eb37fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add 9 regression tests covering 3 codegen issues that are already fixed on main but lacked test coverage.
--platform:x64no longer setsBit32MachinePE flagunmangedgeneric constraint is not recognized by C# #11935 —unmanagedconstraint emitsmodreq+IsUnmanagedAttributefor C# interop (fixed by Better generic unmanaged structs handling ++ bidirectional F#/C# interop for 'unmanaged' constraint #12154)All tests pass on current main without any source changes.