Skip to content

Honor DOTNET_GLOBAL_INSTALL_DIR in activation scripts - #38990

Open
AndriySvyryd with Copilot wants to merge 1 commit into
mainfrom
copilot/honor-dotnet-global-install-dir
Open

AndriySvyryd with Copilot wants to merge 1 commit into
mainfrom
copilot/honor-dotnet-global-install-dir

Conversation

Copilot AI commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

activate.ps1 and activate.sh now align with startvs.cmd when a global .NET install directory is configured.

Changes

  • Use DOTNET_GLOBAL_INSTALL_DIR as DOTNET_ROOT when non-empty.
  • Retain the repository-local .dotnet directory as the fallback.
DOTNET_GLOBAL_INSTALL_DIR=/path/to/dotnet
source ./activate.sh
# DOTNET_ROOT=/path/to/dotnet

Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No unresolved review comments remain.

Pull request overview

Updates activation scripts to honor DOTNET_GLOBAL_INSTALL_DIR while retaining .dotnet as the fallback.

Changes:

  • Updated Bash activation logic.
  • Updated PowerShell activation logic.
File summaries
File Description
activate.sh Selects the global directory or local fallback.
activate.ps1 Selects the global directory or local fallback.
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

@AndriySvyryd
AndriySvyryd marked this pull request as ready for review September 14, 2026 20:37
@AndriySvyryd
AndriySvyryd requested a review from a team as a code owner September 14, 2026 20:37
@AndriySvyryd
AndriySvyryd enabled auto-merge (squash) September 15, 2026 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants