Format vector floats with the invariant culture in SqlServerVectorTyp… - #38725
Open
ilkertskn wants to merge 1 commit into
Open
Format vector floats with the invariant culture in SqlServerVectorTyp…#38725ilkertskn wants to merge 1 commit into
ilkertskn wants to merge 1 commit into
Conversation
…eMapping
- GenerateNonNullSqlLiteral appended each float via StringBuilder.Append(float), which formats with
the current culture, so a vector literal such as CAST('[1.5,2.5]' AS VECTOR(2)) became
CAST('[1,5,2,5]' AS VECTOR(2)) under cultures with a comma decimal separator (e.g. de-DE)
- Format each float with "R" and CultureInfo.InvariantCulture, matching FloatTypeMapping
- Add a test under a non-invariant culture
Contributor
Author
|
@dotnet-policy-service agree |
There was a problem hiding this comment.
Pull request overview
Fixes SQL Server vector SQL literal generation to be culture-invariant when formatting float elements, preventing incorrect decimal separators under non-invariant cultures.
Changes:
- Format vector float elements with
"R"andCultureInfo.InvariantCultureinSqlServerVectorTypeMapping.GenerateNonNullSqlLiteral. - Add a regression test running under
de-DEto validate invariant-culture formatting for vector literals.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/EFCore.SqlServer/Storage/Internal/SqlServerVectorTypeMapping.cs | Formats float vector elements using invariant culture to avoid culture-dependent decimal separators in generated SQL literals. |
| test/EFCore.SqlServer.Tests/Storage/SqlServerTypeMappingTest.cs | Adds a de-DE culture regression test ensuring generated vector SQL literals use . as decimal separator. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…eMapping