Skip to content

Switch Microsoft.Data.Sqlite to SQLite3MC.PCLRaw.bundle#38402

Open
Copilot wants to merge 1 commit into
mainfrom
copilot/change-sqlite-dependency
Open

Switch Microsoft.Data.Sqlite to SQLite3MC.PCLRaw.bundle#38402
Copilot wants to merge 1 commit into
mainfrom
copilot/change-sqlite-dependency

Conversation

Copilot AI commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Part of #38257

Changes the Microsoft.Data.Sqlite meta-package to bundle SQLite3MC.PCLRaw.bundle instead of SQLitePCLRaw.bundle_e_sqlite3, giving shipped consumers a native SQLite build with encryption (SQLite3 Multiple Ciphers) by default, while keeping test coverage for both providers.

Changes

  • Product dependencysrc/Microsoft.Data.Sqlite/Microsoft.Data.Sqlite.csproj now references SQLite3MC.PCLRaw.bundle.
  • Package version plumbing — moved the SQLite3MC.PCLRaw.bundle PackageVersion (pinned to the existing $(SQLite3MCPCLRawBundleVersion)) from test/Directory.Packages.props up to the root Directory.Packages.props, so the non-test product project resolves it; removed the now-duplicate test entry.

Test coverage

No structural test change required — the existing provider matrix already exercises both bundles via separate projects and DefineConstants:

  • Microsoft.Data.Sqlite.TestsE_SQLITE3 / SQLitePCLRaw.bundle_e_sqlite3
  • Microsoft.Data.Sqlite.sqlite3mc.TestsSQLITE3MC / SQLite3MC.PCLRaw.bundle

Notes

  • EFCore.Sqlite and the SQLite benchmarks intentionally remain on bundle_e_sqlite3; this change is scoped to the Microsoft.Data.Sqlite package.

Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Microsoft.Data.Sqlite meta-package to depend on the SQLite3 Multiple Ciphers (SQLite3MC) bundle by default, and moves the corresponding central package version to the repo root so the product project can resolve it.

Changes:

  • Switched src/Microsoft.Data.Sqlite/Microsoft.Data.Sqlite.csproj from SQLitePCLRaw.bundle_e_sqlite3 to SQLite3MC.PCLRaw.bundle.
  • Moved the central PackageVersion for SQLite3MC.PCLRaw.bundle from test/Directory.Packages.props to the root Directory.Packages.props and removed the duplicate test-only entry.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
test/Directory.Packages.props Removes the test-local central version entry now that the version is defined at the repo root.
src/Microsoft.Data.Sqlite/Microsoft.Data.Sqlite.csproj Changes the meta-package dependency to SQLite3MC.PCLRaw.bundle so consumers get SQLite3MC by default.
Directory.Packages.props Adds the central version entry for SQLite3MC.PCLRaw.bundle to support product builds.

@AndriySvyryd AndriySvyryd marked this pull request as ready for review June 10, 2026 21:32
@AndriySvyryd AndriySvyryd requested a review from a team as a code owner June 10, 2026 21:32
@AndriySvyryd AndriySvyryd requested a review from SamMonoRT June 10, 2026 21:33
@AndriySvyryd

Copy link
Copy Markdown
Member

@artl93 @jeffhandley @ViveliDuCh FYI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants