Skip to content

Show a warning when the PMC tools are used with a platform-specific app#38000

Open
Copilot wants to merge 3 commits intomainfrom
copilot/update-pmc-tools-similar-efcore-37868
Open

Show a warning when the PMC tools are used with a platform-specific app#38000
Copilot wants to merge 3 commits intomainfrom
copilot/update-pmc-tools-similar-efcore-37868

Conversation

Copy link
Contributor

Copilot AI commented Mar 25, 2026

Follow up to #37868 for the Package Manager Console tools.

…, inline helper

Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
Agent-Logs-Url: https://github.com/dotnet/efcore/sessions/55267e08-667f-4ff4-8181-dd67b66dae0a
Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
Agent-Logs-Url: https://github.com/dotnet/efcore/sessions/d37e057a-ba63-4672-a8ec-808574c75bc9
Copilot AI requested a review from AndriySvyryd March 25, 2026 20:30
@AndriySvyryd AndriySvyryd marked this pull request as ready for review March 25, 2026 20:31
@AndriySvyryd AndriySvyryd requested a review from a team as a code owner March 25, 2026 20:31
Copilot AI review requested due to automatic review settings March 25, 2026 20:31
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aligns the EF Core Package Manager Console (PMC) tools behavior with the dotnet ef CLI by warning when the startup project targets a platform-specific TFM (e.g. net8.0-windows10.0.19041.0) or has a TargetPlatformIdentifier, since design-time tooling can behave unexpectedly in these scenarios.

Changes:

  • Emit a PMC Write-Warning for platform-specific startup projects detected via TargetPlatformIdentifier or a TargetFramework containing -.
  • Preserve the existing error behavior for non-Windows TargetPlatformIdentifier values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants