Skip to content

Remove remarks about out of support .NET versions (System.R*, System.S*, System.T*)#12862

Open
gewarren wants to merge 4 commits into
dotnet:mainfrom
gewarren:netcore-set3
Open

Remove remarks about out of support .NET versions (System.R*, System.S*, System.T*)#12862
gewarren wants to merge 4 commits into
dotnet:mainfrom
gewarren:netcore-set3

Conversation

@gewarren

@gewarren gewarren commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Contributes to #12648.

Comment thread xml/System.Reflection/IReflect.xml Outdated
Comment thread xml/System.Runtime.InteropServices/RuntimeInformation.xml Outdated
Comment thread xml/System.Runtime.Serialization.Formatters.Binary/BinaryFormatter.xml Outdated
Comment thread xml/System.Runtime.Serialization.Formatters.Binary/BinaryFormatter.xml Outdated
Comment thread xml/System.Text.Json.Serialization/JsonIncludeAttribute.xml Outdated
Comment thread xml/System.Text.Json/Utf8JsonWriter.xml Outdated
Comment thread xml/System.Text.Json/Utf8JsonWriter.xml Outdated
Comment thread xml/System.Text/Encoding.xml
Comment thread xml/System.Threading/ReaderWriterLockSlim.xml Outdated
Comment thread xml/System.Threading/ReaderWriterLockSlim.xml Outdated
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@gewarren gewarren marked this pull request as ready for review July 7, 2026 04:11
Copilot AI review requested due to automatic review settings July 7, 2026 04:11

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates .NET API reference XML docs to remove or generalize remarks that reference out-of-support .NET (Core/5/6/7) versions, aligning the content with the goal in #12648.

Changes:

  • Removed version-qualified remarks and notes across multiple APIs (threading, crypto, interop, reflection, text/JSON).
  • Simplified framework/version language in tables and exception descriptions.
  • Adjusted some wording to be version-neutral (for example, “starting in .NET X” → unconditional statements).

Reviewed changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated 11 comments.

Show a summary per file
File Description
xml/System.Threading/ReaderWriterLockSlim.xml Simplifies NOTE content about lock behavior.
xml/System.Threading.Tasks/Task.xml Updates exception documentation to remove version-dependent limits.
xml/System.Text/Encoding.xml Collapses encoding support table columns and updates UTF-7 note text.
xml/System.Text.Json/Utf8JsonWriter.xml Removes framework/version-specific numeric formatting notes.
xml/System.Text.Json/Utf8JsonReader.xml Removes version-specific performance guidance.
xml/System.Text.Json.Serialization/JsonIncludeAttribute.xml Removes .NET 6/7 limitation note.
xml/System.Security.Cryptography/TripleDESCng.xml Removes version prefix from exception descriptions.
xml/System.Security.Cryptography/Oid.xml Removes version qualifiers around property semantics/exceptions.
xml/System.Security.Cryptography/FromBase64Transform.xml Removes version-dependent behavior explanation for multi-block transform support.
xml/System.Security.Cryptography/CryptoStream.xml Removes “Starting in .NET 6” qualifier from partial-read behavior notes.
xml/System.Security.Cryptography/AesCng.xml Removes version prefix from exception descriptions.
xml/System.Security.Authentication/SslProtocols.xml Removes “starting in .NET 7” phrasing from obsoletion summaries.
xml/System.Runtime.Loader/AssemblyLoadContext.xml Removes .NET Core 2.0–2.2-specific guidance.
xml/System.Runtime.InteropServices/RuntimeInformation.xml Rewords emulation behavior note to be version-neutral.
xml/System.Runtime.InteropServices/NativeLibrary.xml Removes “Starting with .NET 5” qualifier in resolver behavior remark.
xml/System.Runtime.InteropServices/Marshal.xml Removes version qualifiers around NativeMemory and last-error guidance.
xml/System.Runtime.InteropServices/DllImportAttribute.xml Simplifies last-error retrieval guidance to version-neutral wording.
xml/System.Reflection/IReflect.xml Adjusts version ranges described for COM casting behavior.
xml/System.Reflection/Assembly.xml Removes/relaxes version qualifiers for bundled assembly exception and obsoletion remark.

Comment thread xml/System.Threading.Tasks/Task.xml
Comment thread xml/System.Threading.Tasks/Task.xml
Comment thread xml/System.Text/Encoding.xml
Comment thread xml/System.Runtime.InteropServices/DllImportAttribute.xml
Comment thread xml/System.Runtime.InteropServices/Marshal.xml
Comment thread xml/System.Runtime.InteropServices/Marshal.xml
Comment thread xml/System.Security.Cryptography/Oid.xml
Comment thread xml/System.Security.Cryptography/Oid.xml
Comment thread xml/System.Security.Cryptography/FromBase64Transform.xml
Comment thread xml/System.Threading/ReaderWriterLockSlim.xml
## List of encodings

The following table lists the encodings supported by .NET. It lists each encoding's code page number and the values of the encoding's <xref:System.Text.EncodingInfo.Name?displayProperty=nameWithType> and <xref:System.Text.EncodingInfo.DisplayName?displayProperty=nameWithType> properties. A check mark in the **.NET Framework support**, **.NET Core support**, or **.NET 5 and later support** column indicates that the code page is natively supported by that .NET implementation, regardless of the underlying platform. For .NET Framework, the availability of other encodings listed in the table depends on the operating system. For .NET Core and .NET 5 and later versions, other encodings are available by using the <xref:System.Text.CodePagesEncodingProvider?displayProperty=nameWithType> class or by deriving from the <xref:System.Text.EncodingProvider?displayProperty=nameWithType> class.
The following table lists the encodings supported by .NET. It lists each encoding's code page number and the values of the encoding's <xref:System.Text.EncodingInfo.Name?displayProperty=nameWithType> and <xref:System.Text.EncodingInfo.DisplayName?displayProperty=nameWithType> properties. A check mark in the **.NET support** column indicates that the code page is natively supported by .NET, regardless of the underlying platform.Other encodings are available by using the <xref:System.Text.CodePagesEncodingProvider?displayProperty=nameWithType> class or by deriving from the <xref:System.Text.EncodingProvider?displayProperty=nameWithType> class.

@wadepickett wadepickett Jul 7, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The following table lists the encodings supported by .NET. It lists each encoding's code page number and the values of the encoding's <xref:System.Text.EncodingInfo.Name?displayProperty=nameWithType> and <xref:System.Text.EncodingInfo.DisplayName?displayProperty=nameWithType> properties. A check mark in the **.NET support** column indicates that the code page is natively supported by .NET, regardless of the underlying platform.Other encodings are available by using the <xref:System.Text.CodePagesEncodingProvider?displayProperty=nameWithType> class or by deriving from the <xref:System.Text.EncodingProvider?displayProperty=nameWithType> class.
The following table lists the encodings supported by .NET. It lists each encoding's code page number and the values of the encoding's <xref:System.Text.EncodingInfo.Name?displayProperty=nameWithType> and <xref:System.Text.EncodingInfo.DisplayName?displayProperty=nameWithType> properties. A check mark in the **.NET support** column indicates that the code page is natively supported by .NET, regardless of the underlying platform. Other encodings are available by using the <xref:System.Text.CodePagesEncodingProvider?displayProperty=nameWithType> class or by deriving from the <xref:System.Text.EncodingProvider?displayProperty=nameWithType> class.

Very minor, just a missing space.

@wadepickett wadepickett left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gewarren , approved assuming current suggestions fixed. I only found one tiny nit beyond what Copilot already suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants