Fix CLS example: keep private field as UInt16 - #55954
Open
sharadvc wants to merge 1 commit into
Open
Conversation
The language-independence docs explain that only the public Age property must use a CLS-compliant type. Leave the private personAge field as UInt16 and cast when exposing the Int16 property. Fixes dotnet#49691 Co-authored-by: Sharad. <sharadvc@users.noreply.github.com>
dotnet-policy-service
Bot
added
the
community-contribution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The language-independence article explains that only the public
Ageproperty must use a CLS-compliant type. The C# snippet for the corrected example incorrectly changed the privatepersonAgefield toInt16as well.This change keeps
personAgeasUInt16and casts toInt16in the public property getter.Fixes #49691
Internal previews
Build report