This repository was archived by the owner on Mar 17, 2021. It is now read-only.
Correctly detect Debian in perfcollect#72
Open
mleenhardt wants to merge 1 commit intodotnet:masterfrom
Open
Conversation
`uname -a` doesn't contain "Debian" on Jessie or Stretch. Output from a microsoft/dotnet:2.0.6-sdk-2.1.104 container using stretch as its base image: `uname -a` -> "Linux 1a46aee325a3 4.9.87-linuxkit-aufs dotnet#1 SMP Wed Mar 14 15:12:16 UTC 2018 x86_64 GNU/Linux" `cat /etc/debian_version` -> "8.10" `cat /etc/issues` -> "Debian GNU/Linux 8 \n \l" Output from a microsoft/dotnet:2.0.6-sdk-2.1.104-jessie container using jessie as its base image: `uname -a` -> "Linux ae834cf8bd36 4.9.87-linuxkit-aufs dotnet#1 SMP Wed Mar 14 15:12:16 UTC 2018 x86_64 GNU/Linux" `cat /etc/debian_version` -> "9.4" `cat /etc/issues` -> "Debian GNU/Linux 9 \n \l"
Member
|
I am not sure why don't we use the standard distro detection way that we use in all of our build and tool initialization scripts in coreclr, corefx and core-setup. The /etc/os-release is the best source of truth for these purposes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uname -adoesn't contain "Debian" on Jessie or Stretch.Output from a microsoft/dotnet:2.0.6-sdk-2.1.104 container using stretch as its base image:
uname -a-> "Linux 1a46aee325a3 4.9.87-linuxkit-aufs #1 SMP Wed Mar 14 15:12:16 UTC 2018 x86_64 GNU/Linux"cat /etc/debian_version-> "8.10"cat /etc/issues-> "Debian GNU/Linux 8 \n \l"Output from a microsoft/dotnet:2.0.6-sdk-2.1.104-jessie container using jessie as its base image:
uname -a-> "Linux ae834cf8bd36 4.9.87-linuxkit-aufs #1 SMP Wed Mar 14 15:12:16 UTC 2018 x86_64 GNU/Linux"cat /etc/debian_version-> "9.4"cat /etc/issues-> "Debian GNU/Linux 9 \n \l"Running
./perfcollect installin the above two containers with the current version that's checking foruname -aresults in "ERROR: Auto install unsupported for this distribution. Install perf manually to continue."