Fix typos in code#67428
Open
cincuranet wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR applies a repository-wide pass of typo fixes (primarily in comments, XML docs, and markdown/spec docs) based on codespell, while intentionally excluding areas where “typos” are often intentional or breaking (e.g., PublicAPI.txt and specific public API identifiers).
Changes:
- Corrects spelling/grammar in documentation (README/spec/PACKAGE.md files) and code comments across multiple subcomponents (SignalR, Kestrel/IIS/HttpSys servers, MVC, Routing, Components, etc.).
- Fixes typos in developer-facing strings and doc comments (e.g., exception messages, XML doc text).
- Fixes a small number of misspelled local identifiers/variables.
Reviewed changes
Copilot reviewed 169 out of 174 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Tools/README.md | README typo fix. |
| src/SignalR/server/Specification.Tests/src/ScaleoutHubLifetimeManagerTests.cs | Test comment typo fix. |
| src/SignalR/docs/specs/HubProtocol.md | Spec doc typo fix. |
| src/SignalR/common/SignalR.Common/src/Protocol/HandshakeProtocol.cs | Comment typo fix. |
| src/SignalR/common/Http.Connections.Common/src/AvailableTransport.cs | XML doc typo fix. |
| src/SignalR/clients/ts/FunctionalTests/ts/HubConnectionTests.ts | Test description typo fix. |
| src/SignalR/clients/java/signalr/core/src/main/java/com/microsoft/signalr/LongPollingTransport.java | Comment typo fix. |
| src/SignalR/clients/csharp/Http.Connections.Client/src/HttpConnection.cs | Comment typo fix. |
| src/SignalR/clients/csharp/Client.Core/src/HubConnectionExtensions.StreamAsChannelAsync.cs | Comment typo fix. |
| src/SignalR/clients/csharp/Client.Core/src/HubConnection.cs | Comment typo fix. |
| src/Shared/StaticWebAssets/ManifestStaticWebAssetFileProvider.cs | Comment typo fix. |
| src/Shared/ServerInfrastructure/StringUtilities.cs | Comment typo fixes. |
| src/Shared/PathNormalizer/PathNormalizer.cs | Comment typo fix. |
| src/Shared/ParameterBindingMethodCache.cs | Comment typo fix. |
| src/Shared/Http2cat/Http2CatReadMe.md | README typo fix. |
| src/Shared/Hpack/DynamicHPackEncoder.cs | XML doc typo fix. |
| src/Shared/CertificateGeneration/UnixCertificateManager.cs | Comment typo fix. |
| src/Shared/CertificateGeneration/CertificateManager.cs | Attribute justification typo fix. |
| src/Servers/README.md | README typo fix. |
| src/Servers/Kestrel/tools/CodeGenerator/HttpUtilities/HttpUtilities.cs | Exception message typo fix. |
| src/Servers/Kestrel/shared/Http2HeadersEnumerator.cs | Comment typo fix. |
| src/Servers/Kestrel/shared/HPackHeaderWriter.cs | Comment typo fix. |
| src/Servers/Kestrel/Core/src/Middleware/HttpsConnectionMiddleware.cs | Comment typo fix. |
| src/Servers/Kestrel/Core/src/KestrelServerOptions.cs | XML doc typo fix. |
| src/Servers/Kestrel/Core/src/Internal/Infrastructure/TimeoutControl.cs | Comment typo fixes. |
| src/Servers/Kestrel/Core/src/Internal/Infrastructure/KestrelMetrics.cs | Comment typo fixes. |
| src/Servers/Kestrel/Core/src/Internal/Infrastructure/KestrelEventSource.cs | Attribute justification typo fixes. |
| src/Servers/Kestrel/Core/src/Internal/Http3/Http3Connection.cs | Comment typo fixes. |
| src/Servers/Kestrel/Core/src/Internal/Http/HttpProtocol.cs | Comment typo fixes. |
| src/Servers/Kestrel/Core/src/Internal/Http/HttpHeaders.cs | Comment typo fixes. |
| src/Servers/Kestrel/Core/src/Internal/Http/ChunkWriter.cs | Comment typo fix. |
| src/Servers/Kestrel/Core/src/Internal/ConfigurationReader.cs | Comment typo fix. |
| src/Servers/Kestrel/Core/src/HttpsConfigurationService.cs | Comment typo fix. |
| src/Servers/Kestrel/Core/src/Features/ITlsApplicationProtocolFeature.cs | XML doc typo fix. |
| src/Servers/IIS/AspNetCoreModuleV2/RequestHandlerLib/requesthandler_config.cpp | Comment typo fixes. |
| src/Servers/IIS/AspNetCoreModuleV2/OutOfProcessRequestHandler/websockethandler.cpp | Comment typo fixes. |
| src/Servers/IIS/AspNetCoreModuleV2/OutOfProcessRequestHandler/forwardinghandler.cpp | Comment typo fix. |
| src/Servers/IIS/AspNetCoreModuleV2/CommonLib/HostFxrResolver.h | Parameter name typo fix. |
| src/Servers/IIS/AspNetCoreModuleV2/CommonLib/fx_ver.cpp | Comment typo fixes. |
| src/Servers/HttpSys/src/SourceBuildStubs.cs | XML doc typo fix. |
| src/Servers/HttpSys/src/RequestProcessing/RequestStreamAsyncResult.cs | Comment typo fix. |
| src/Servers/HttpSys/src/NativeInterop/RequestQueue.cs | XML doc typo fix. |
| src/Servers/HttpSys/src/IHttpSysRequestInfoFeature.cs | XML doc typo fix. |
| src/Security/Authentication/Negotiate/src/NegotiateOptions.cs | XML doc typo fixes. |
| src/Security/Authentication/Negotiate/src/NegotiateHandler.cs | Comment typo fix. |
| src/Security/Authentication/Core/src/IDataSerializer.cs | XML doc typo fix. |
| src/Security/Authentication/Certificate/src/CertificateAuthenticationExtensions.cs | XML doc typo fix. |
| src/Mvc/Mvc.ViewFeatures/src/MvcViewFeaturesDiagnosticListenerExtensions.cs | Comment typo fixes. |
| src/Mvc/Mvc.ViewFeatures/src/HtmlHelper.cs | XML doc typo fixes. |
| src/Mvc/Mvc.ViewFeatures/src/Filters/SaveTempDataFilter.cs | Comment typo fix. |
| src/Mvc/Mvc.Testing/src/WebApplicationFactory.cs | XML doc typo fix. |
| src/Mvc/Mvc.TagHelpers/src/CacheTagHelper.cs | Comment typo fix. |
| src/Mvc/Mvc.RazorPages/src/MvcRazorPagesDiagnosticListenerExtensions.cs | Comment typo fixes. |
| src/Mvc/Mvc.RazorPages/src/Infrastructure/PageActionInvokerProvider.cs | Comment typo fix. |
| src/Mvc/Mvc.RazorPages/src/Builder/RazorPagesEndpointRouteBuilderExtensions.cs | XML doc typo fixes. |
| src/Mvc/Mvc.RazorPages/src/ApplicationModels/DefaultPageApplicationModelProvider.cs | Comment typo fix. |
| src/Mvc/Mvc.RazorPages/src/ApplicationModels/CompiledPageActionDescriptorBuilder.cs | Comment typo fix. |
| src/Mvc/Mvc.Razor/src/MvcRazorDiagnosticListenerExtensions.cs | Comment typo fixes. |
| src/Mvc/Mvc.Razor.RuntimeCompilation/src/FileProviderRazorProjectItem.cs | XML doc typo fixes. |
| src/Mvc/Mvc.NewtonsoftJson/src/NewtonsoftJsonInputFormatter.cs | Comment typo fix. |
| src/Mvc/Mvc.Core/src/Routing/ActionEndpointFactory.cs | Comment typo fix. |
| src/Mvc/Mvc.Core/src/Routing/ActionEndpointDataSourceBase.cs | Comment typo fix. |
| src/Mvc/Mvc.Core/src/ModelBinding/Validation/ValidationVisitor.cs | XML doc typo fixes. |
| src/Mvc/Mvc.Core/src/Infrastructure/FileResultExecutorBase.cs | XML doc typo fix. |
| src/Mvc/Mvc.Core/src/Infrastructure/FileContentResultExecutor.cs | XML doc typo fix. |
| src/Mvc/Mvc.Core/src/Infrastructure/AsyncEnumerableReader.cs | XML doc typo fix. |
| src/Mvc/Mvc.Core/src/Builder/ControllerEndpointRouteBuilderExtensions.cs | XML doc typo fixes. |
| src/Mvc/Mvc.Core/src/Authorization/AuthorizeFilter.cs | Comment typo fix. |
| src/Mvc/Mvc.Core/src/ApplicationModels/SelectorModel.cs | XML doc typo fixes. |
| src/Mvc/Mvc.Core/src/ApplicationModels/ActionAttributeRouteModel.cs | Comment typo fix. |
| src/Mvc/Mvc.Core/src/ApiExplorer/ApiConventionTypeMatchAttribute.cs | XML doc typo fix. |
| src/Mvc/Mvc.ApiExplorer/src/EndpointMetadataApiDescriptionProvider.cs | Comment typo fix. |
| src/Mvc/Mvc.Api.Analyzers/src/ActualApiResponseMetadataFactory.cs | XML doc typo fix. |
| src/Mvc/Mvc.Abstractions/src/ModelBinding/ModelStateDictionary.cs | XML doc typo fix. |
| src/Middleware/StaticFiles/src/StaticFilesEndpointRouteBuilderExtensions.cs | XML doc typo fixes. |
| src/Middleware/Spa/SpaServices.Extensions/src/Npm/NodeScriptRunner.cs | Error message typo fix. |
| src/Middleware/Spa/SpaProxy/src/SpaProxyLaunchManager.cs | Comment typo fix. |
| src/Middleware/Rewrite/src/IISUrlRewriteOptionsExtensions.cs | Attribute justification typo fix. |
| src/Middleware/Rewrite/src/ApacheModRewrite/ConditionPatternParser.cs | Comment typo fix. |
| src/Middleware/ResponseCompression/src/ResponseCompressionBody.cs | Comment typo fix. |
| src/Middleware/RateLimiting/src/DefaultCombinedLease.cs | Comment typo fix. |
| src/Middleware/OutputCaching/src/OutputCachePolicyBuilder.cs | XML doc typo fixes. |
| src/Middleware/HttpOverrides/src/CertificateForwardingServiceExtensions.cs | XML doc typo fix. |
| src/Middleware/HeaderPropagation/src/HeaderPropagationMiddleware.cs | Comment typo fix. |
| src/Middleware/CORS/src/Infrastructure/CorsPolicyBuilder.cs | XML doc typo fix. |
| src/JSInterop/Microsoft.JSInterop/src/JSRuntime.cs | XML doc typo fixes. |
| src/JSInterop/Microsoft.JSInterop/src/Infrastructure/DotNetDispatcher.cs | XML doc typo fixes. |
| src/JSInterop/Microsoft.JSInterop.JS/src/src/Microsoft.JSInterop.ts | TS doc typo fix. |
| src/Installers/Windows/Wix.targets | Comment typo fix. |
| src/Installers/Windows/AspNetCoreModule-Setup/IIS-Setup/iisca/lib/setup_log.cpp | Comment typo fix. |
| src/Installers/Windows/AspNetCoreModule-Setup/IIS-Setup/iisca/lib/secutils.cpp | Comment typo fixes. |
| src/Installers/Windows/AspNetCoreModule-Setup/IIS-Setup/iisca/lib/msiutil.cpp | Log message typo fix. |
| src/Installers/Windows/AspNetCoreModule-Setup/IIS-Setup/iisca/lib/hotfix.cpp | Log message typo fixes. |
| src/Installers/Windows/AspNetCoreModule-Setup/IIS-Setup/iisca/lib/elevatedsc.cpp | Comment typo fix. |
| src/Installers/Windows/AspNetCoreModule-Setup/IIS-Setup/iisca/lib/consoleprops.cpp | Comment typo fixes. |
| src/Identity/UI/src/assets/V5/lib/jquery-validation/dist/jquery.validate.js | Vendor comment typo fix. |
| src/Identity/UI/src/assets/V5/lib/jquery-validation/dist/additional-methods.js | Vendor comment typo fixes. |
| src/Identity/UI/src/assets/V4/lib/jquery-validation/dist/jquery.validate.js | Vendor comment typo fix. |
| src/Identity/UI/src/assets/V4/lib/jquery-validation/dist/additional-methods.js | Vendor comment typo fixes. |
| src/Identity/UI/src/assets/V4/lib/bootstrap/dist/js/bootstrap.bundle.js | Vendor comment typo fixes. |
| src/Identity/Extensions.Stores/src/UserStoreBase.cs | Attribute justification typo fix. |
| src/Identity/Extensions.Stores/src/RoleStoreBase.cs | Attribute justification typo fix. |
| src/Http/Routing/src/Tree/UrlMatchingTree.cs | Comment typo fixes. |
| src/Http/Routing/src/Tree/OutboundRouteEntry.cs | XML doc typo fix. |
| src/Http/Routing/src/Template/TemplateValuesResult.cs | XML doc typo fix. |
| src/Http/Routing/src/Template/TemplatePart.cs | XML doc typo fixes. |
| src/Http/Routing/src/Template/TemplateBinder.cs | Comment/XML doc typo fixes. |
| src/Http/Routing/src/Template/RoutePrecedence.cs | Comment typo fix. |
| src/Http/Routing/src/SuppressLinkGenerationMetadata.cs | XML doc typo fix. |
| src/Http/Routing/src/RouteEndpointDataSource.cs | Comment typo fix. |
| src/Http/Routing/src/Patterns/RoutePatternFactory.cs | XML doc typo fixes. |
| src/Http/Routing/src/Matching/ILEmitTrieFactory.cs | Comment typo fix. |
| src/Http/Routing/src/Matching/HttpMethodMatcherPolicy.cs | Comment typo fixes. |
| src/Http/Routing/src/Matching/DfaMatcherBuilder.cs | Comment + local identifier typo fixes. |
| src/Http/Routing/src/Matching/ContentEncodingMetadata.cs | XML doc typo fix. |
| src/Http/Routing/src/InlineRouteParameterParser.cs | Comment typo fix. |
| src/Http/Http/src/StreamResponseBodyFeature.cs | XML doc typo fix. |
| src/Http/Http/src/Features/RouteValuesFeature.cs | XML doc typo fix. |
| src/Http/Http.Features/src/IServiceProvidersFeature.cs | XML doc typo fix. |
| src/Http/Http.Extensions/gen/Microsoft.AspNetCore.Http.RequestDelegateGenerator/StaticRouteHandlerModel/StaticRouteHandlerModel.Emitter.cs | Comment typo fix. |
| src/Http/Http.Extensions/gen/Microsoft.AspNetCore.Http.RequestDelegateGenerator/StaticRouteHandlerModel/Emitters/EndpointParameterEmitter.cs | Comment typo fix. |
| src/Http/Http.Abstractions/src/Routing/RouteValueDictionary.cs | Attribute message typo fix. |
| src/Http/Http.Abstractions/src/QueryString.cs | XML doc typo fix. |
| src/Http/Http.Abstractions/src/Metadata/IRouteDiagnosticsMetadata.cs | XML doc typo fix. |
| src/Http/Http.Abstractions/src/IEndpointFilter.cs | XML doc typo fix. |
| src/Http/Http.Abstractions/src/HttpProtocol.cs | XML doc typo fix. |
| src/Http/Http.Abstractions/src/HostString.cs | XML doc typo fix. |
| src/Http/Http.Abstractions/src/FragmentString.cs | XML doc typo fix. |
| src/Http/Headers/src/SetCookieHeaderValue.cs | Comment typo fix. |
| src/Http/Authentication.Abstractions/src/IAuthenticationConfigurationProvider.cs | XML doc typo fix. |
| src/Hosting/TestHost/src/UpgradeFeature.cs | Comment typo fix. |
| src/Hosting/Server.IntegrationTesting/src/Deployers/RemoteWindowsDeployer/RemotePSSessionHelper.ps1 | Comment typo fix. |
| src/Hosting/Hosting/src/Internal/HostingApplicationDiagnostics.cs | Comment typo fix. |
| src/Grpc/JsonTranscoding/src/Shared/X509CertificateHelpers.cs | Comment typo fixes. |
| src/Grpc/JsonTranscoding/src/Shared/ServiceDescriptorHelpers.cs | Comment typo fix. |
| src/Grpc/JsonTranscoding/src/Shared/Server/MethodOptions.cs | XML doc typo fixes. |
| src/Grpc/JsonTranscoding/src/Shared/Server/BindMethodFinder.cs | Comment typo fix. |
| src/Grpc/JsonTranscoding/src/Microsoft.AspNetCore.Grpc.JsonTranscoding/Internal/JsonTranscodingServerCallContext.cs | Comment typo fix. |
| src/Grpc/JsonTranscoding/src/Microsoft.AspNetCore.Grpc.JsonTranscoding/Internal/JsonTranscodingRouteAdapter.cs | Comment typo fix. |
| src/Framework/AspNetCoreAnalyzers/src/CodeFixes/Dependencies/ExtensionMethodsCompletionProvider.cs | XML doc typo fix. |
| src/Framework/AspNetCoreAnalyzers/src/Analyzers/RouteEmbeddedLanguage/Infrastructure/RouteUsageDetector.cs | Local identifier typo fixes. |
| src/Framework/AspNetCoreAnalyzers/src/Analyzers/RouteEmbeddedLanguage/FrameworkParametersCompletionProvider.cs | Local identifier typo fixes. |
| src/Framework/AspNetCoreAnalyzers/src/Analyzers/Infrastructure/VirtualChars/VirtualCharSequence.cs | XML doc typo fix. |
| src/Framework/AspNetCoreAnalyzers/src/Analyzers/Infrastructure/VirtualChars/CSharpVirtualCharService.cs | Comment typo fix. |
| src/DataProtection/README.md | README typo fix. |
| src/DataProtection/DataProtection/src/XmlEncryption/DpapiNGXmlEncryptor.cs | XML doc typo fix. |
| src/DataProtection/DataProtection/src/Repositories/IDefaultKeyStorageDirectory.cs | XML doc typo fix. |
| src/DataProtection/DataProtection/src/KeyManagement/XmlKeyManager.cs | Comment typo fix. |
| src/Components/WebAssembly/WebAssembly/src/Services/LazyAssemblyLoader.cs | Exception message typo fix. |
| src/Components/WebAssembly/WebAssembly/src/Hosting/WebAssemblyCallQueue.cs | Comment typo fix. |
| src/Components/WebAssembly/WebAssembly.Authentication/src/Services/AccessTokenNotAvailableException.cs | XML doc typo fix. |
| src/Components/WebAssembly/WebAssembly.Authentication/src/PACKAGE.md | Doc typo fix. |
| src/Components/WebAssembly/WebAssembly.Authentication/src/Models/InteractiveRequestOptions.cs | Attribute justification typo fix. |
| src/Components/WebAssembly/Server/src/TargetPickerUi.cs | Comment typo fix. |
| src/Components/WebAssembly/Authentication.Msal/src/PACKAGE.md | Doc typo fix. |
| src/Components/Web.JS/src/Services/WebRootComponentManager.ts | Comment typo fixes. |
| src/Components/Web.JS/src/Rendering/DomMerging/DomSync.ts | Comment typo fix. |
| src/Components/Web.JS/src/JSInitializers/JSInitializers.ts | Comment typo fix. |
| src/Components/Web.JS/src/GlobalExports.ts | Comment typo fix. |
| src/Components/Server/src/ComponentHub.cs | Comment typo fixes. |
| src/Components/Server/src/Circuits/DefaultInMemoryCircuitPersistenceProvider.cs | Comment typo fix. |
| src/Components/Server/src/Circuits/CircuitRegistry.cs | XML doc typo fixes. |
| src/Components/Server/src/Circuits/CircuitHost.cs | Local identifier + log message typo fixes. |
| src/Components/QuickGrid/Microsoft.AspNetCore.Components.QuickGrid/src/QuickGrid.razor.css | Comment typo fix. |
| src/Components/Endpoints/src/FormMapping/Converters/DictionaryConverter.cs | Local identifier typo fixes. |
| src/Components/Endpoints/src/FormMapping/Converters/CollectionConverter.cs | Local identifier + comment typo fixes. |
| src/Components/Components/src/Routing/Router.cs | Comment typo fix. |
| src/Components/Components/src/ResourceAssetCollection.cs | XML doc typo fix. |
| src/Components/Components/src/RenderTree/RenderTreeDiffBuilder.cs | Comment typo fix. |
| src/Components/Components/src/CascadingValueSource.cs | XML doc typo fixes. |
| src/Components/benchmarkapps/Wasm.Performance/TestApp/Pages/PersonDisplay.razor | UI label typo fix. |
| src/Antiforgery/src/Internal/IClaimUidExtractor.cs | XML doc typo fix. |
| src/Analyzers/Microsoft.AspNetCore.Analyzer.Testing/src/DiagnosticAnalyzerRunner.cs | XML doc typo fix. |
| src/Analyzers/Analyzers/src/StartupFacts.cs | Comment typo fix. |
Comment on lines
+106
to
+108
| /// Creates method options by merging together the settings the specified <see cref="GrpcServiceOptions"/> collection. | ||
| /// The <see cref="GrpcServiceOptions"/> should be ordered with items arranged in ascending order of precedence. | ||
| /// When interceptors from multiple options are merged together they will be executed in reverse order of precendence. | ||
| /// When interceptors from multiple options are merged together they will be executed in reverse order of precedence. |
Comment on lines
110
to
+111
| /// <param name="serviceOptions">A collection of <see cref="GrpcServiceOptions"/> instances, arranged in ascending order of precedence.</param> | ||
| /// <returns>A new <see cref="MethodOptions"/> instanced with settings merged from specifid <see cref="GrpcServiceOptions"/> collection.</returns> | ||
| /// <returns>A new <see cref="MethodOptions"/> instanced with settings merged from specified <see cref="GrpcServiceOptions"/> collection.</returns> |
| }); | ||
|
|
||
| it("connection id is alwys null is negotiation is skipped", async () => { | ||
| it("connection id is always null is negotiation is skipped", async () => { |
mikekistler
reviewed
Jun 26, 2026
mikekistler
left a comment
mikekistler
left a comment
Contributor
There was a problem hiding this comment.
I love the fixes to the xmldocs! These will clearly improve developer experience by making the generated reference docs more readable / understandable.
I'm less enthusiastic about the code changes. If we are certain that they do no harm I suppose they are okay, but I'm not sure how to know that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I used
codespellacross the repo, with a curated (Copilot assisted) ignore list and skip patterns to exclude test data, localized installer files (.wxl/.rtf/LCID), submodules, generated code, andPublicAPI.txt- places where "typos" are often intentional (test fixtures, non-English strings, public API names). I restricted auto-fixes to product source, then reviewed the full diff line-by-line.BTW I skipped public-API typo:
FeatureReferences.Initalize. That would be a breaking change.