Skip to content

Add regression test for #1191 (custom IProblemDetailsWriter preservation) #1192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xavierjohn wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add regression test for #1191 (custom IProblemDetailsWriter preservation) #1192

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions ...pi/test/Asp.Versioning.Http.Tests/DependencyInjection/IServiceCollectionExtensionsTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
namespace Microsoft.Extensions.DependencyInjection;

using Asp.Versioning;
using Microsoft.AspNetCore.Http;
using Microsoft.Extensions.Options;

public class IServiceCollectionExtensionsTest
Expand All @@ -25,4 +26,35 @@ public void add_api_versioning_should_not_allow_default_neutral_api_version()
// assert
options.Should().Throw<OptionsValidationException>();
}

// REF: https://github.com/dotnet/aspnet-api-versioning/issues/1191
[Fact]
public void add_api_versioning_should_not_displace_or_wrap_user_registered_problem_details_writers()
{
// arrange
var services = new ServiceCollection();
var customWriter = new TestProblemDetailsWriter();

services.AddProblemDetails();
services.AddSingleton<IProblemDetailsWriter>( customWriter );

var writersBefore = services.Where( s => s.ServiceType == typeof( IProblemDetailsWriter ) ).ToArray();

// act
services.AddApiVersioning();

// assert
var writersAfter = services.Where( s => s.ServiceType == typeof( IProblemDetailsWriter ) ).ToArray();
writersAfter.Should().Equal( writersBefore );

using var provider = services.BuildServiceProvider();
provider.GetServices<IProblemDetailsWriter>().Should().Contain( customWriter );
}

private sealed class TestProblemDetailsWriter : IProblemDetailsWriter
{
public bool CanWrite( ProblemDetailsContext context ) => true;

public ValueTask WriteAsync( ProblemDetailsContext context ) => ValueTask.CompletedTask;
}
}
Loading