[fix-finder] [installer] Enable nullable annotations for JdkArchive - #12787
Open
github-actions[bot] wants to merge 1 commit into
Open
github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
github-actions
Bot
requested review from
jonathanpeppers and
simonrozsival
as code owners
September 15, 2026 02:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
JdkArchivewas one of the shipped installer types still compiled without nullable reference type annotations. Its publicPayloadFileNameproperty can be unset after construction, and its equality methods acceptnull, but those contracts were not represented in the source.Fix
Enabled nullable reference types in
JdkArchive.cs, markedPayloadFileNameand equality parameters nullable, and added the explicit null guard required for the project'snetstandard2.0target.Validation
AndroidSdkDirectory="$GITHUB_WORKSPACE/bin/Debug/android-sdk" AndroidNdkDirectory="$GITHUB_WORKSPACE/bin/Debug/android-ndk" ./build.sh Prepare— passed./dotnet-local.sh build src/Xamarin.Installer.AndroidSDK/Xamarin.Installer.AndroidSDK.csproj— passed with 0 warnings and 0 errorsgit diff --check— passedFix-finder metadata
01-nullable-reference-types29/30(actionability:10, safety:9, scope:10)